Closed Bug 1627602 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22710 - Fix test failures of flex-one-sets-flex-basis-to-zero-px.html in FF

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22710 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22710
Details from upstream follow.

Gyuyoung Kim <gyuyoung@igalia.com> wrote:

Fix test failures of flex-one-sets-flex-basis-to-zero-px.html in FF

Firefox doesn't support only use of document.fonts.ready.then().
So, this CL makes the test follow the existing use of ahem.css.

Bug: 1063749
Change-Id: If27a2a50ed514e42b90aea85122116961d584c6e
Reviewed-on: https://chromium-review.googlesource.com/2134097
WPT-Export-Revision: 3ff2fb4fbbee4bafacafbc259349d3fa49e9addd

PR 22710 applied with additional changes from upstream: abf134e82dd227cf9e2de5c4a958ef5eaa0b5e3f
Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

Gyuyoung gave me a heads-up that this test has some failures on Firefox (though we don't have a Try run posted here yet so no "new WPT test failures" bug has been spawned yet).

I suggested a fix in https://github.com/web-platform-tests/wpt/pull/22551#issuecomment-610178917 and hopefully that'll address the failures.

Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecba88440920
[wpt PR 22710] - Fix test failures of flex-one-sets-flex-basis-to-zero-px.html in Firefox, a=testonly

(In reply to Daniel Holbert [:dholbert] from comment #2)

Gyuyoung gave me a heads-up that this test has some failures on Firefox

(Following up: the test ended up being fixed upstream before it hit autoland, so all's well here.)

https://hg.mozilla.org/mozilla-central/rev/ecba88440920

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.