Closed Bug 1627660 Opened 2 years ago Closed 2 years ago

Flathub failing to consume `stable` flatpak

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(firefox75 wontfix, firefox76 fixed, firefox77 fixed)

RESOLVED FIXED
Tracking Status
firefox75 --- wontfix
firefox76 --- fixed
firefox77 --- fixed

People

(Reporter: mtabara, Assigned: mtabara)

References

Details

Attachments

(1 file)

While our automation was green in building flatpak, turns out for the stable channel there's a few more sanity checks that are performed on the Flathub side that are currently failing. This is to address those.

Two things so far:

  1. looks like appstream-compose(?) failed to find and extract icon - we ought to compose after we move the icons and files inside the installer - https://hg.mozilla.org/integration/autoland/file/tip/taskcluster/docker/firefox-flatpak/runme.sh#l111 appstream-compose line has to be below the org.mozilla.firefox.desktop and icons for loop lines
  2. drop <strong> tags from appdata file as it's not supported at the moment by the tool used by flatpak
Assignee: nobody → mtabara
Status: NEW → ASSIGNED
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1ab3757b1cc
fix Flathub related issues for Flatpak. r=rail

Comment on attachment 9138526 [details]
Bug 1627660 - fix Flathub related issues for Flatpak. r=rail

Beta/Release Uplift Approval Request

  • User impact if declined: None, this is an automation chanege.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is requested so that Flathub sanity checks are fixed. For now, Flathub folks fixed those server-side but for the future releases we should make sure automation works as expected.
  • String changes made/needed:
Attachment #9138526 - Flags: approval-mozilla-beta?

Note to self: once a few betas work later this week, we should uplift this to release as well, just in case of a dot release/chemspill, we don't have to do the whole magic again.

Comment on attachment 9138526 [details]
Bug 1627660 - fix Flathub related issues for Flatpak. r=rail

Beta/Release Uplift Approval Request

  • User impact if declined: None, automation change only.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): We should also uplift to release in case of a chemspill/dot release.
  • String changes made/needed:
Attachment #9138526 - Flags: approval-mozilla-release?
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1441922

Comment on attachment 9138526 [details]
Bug 1627660 - fix Flathub related issues for Flatpak. r=rail

Approved for 76.0b2.

Attachment #9138526 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9138526 [details]
Bug 1627660 - fix Flathub related issues for Flatpak. r=rail

76 goes to RC today.

Attachment #9138526 - Flags: approval-mozilla-release? → approval-mozilla-release-
Component: Release Automation: Flatpak → Release Automation: Other
You need to log in before you can comment on or make changes to this bug.