1627674 - [Wayland] Control borders not drawn when using DMABuf textures

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P3)

Description

[Laurențiu Nicola]

Attachment: borders.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

Run Firefox with MOZ_ENABLE_WAYLAND=1 and widget.wayland-dmabuf-textures.enabled set to true.

Actual results:

Some controls borders like those for checkboxes and buttons are not drawn, or disappear quickly.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Marko Korhonen]

Same issue here. I'm on SwayWM with the latest Nightly. AMD iGPU with amdgpu drivers if that matters. Tried with a clean profile too.

Unfortunately I'm no Firefox developer so I don't know what kind of logs you need. If I run Firefox from the terminal, it constantly spams this error:

[GFX1-]: Failed to create DrawTarget, Type: 3 Size: Size(15,16), Data: 0, Stride: 0

This error is printed every time I press a key while typing this.

Here's a good site to test this issue
When I have dmabuf textures enabled, the form looks like this.

Let me know if you need any more info or testing, I'm happy to help.

Comment 3

[Darkspirit]

Do you both still see this bug after setting gfx.webrender.all to true and restarting Nightly?

Comment 4

[Laurențiu Nicola]

I see it in the latest Nightly with WebRender enabled. It seems to behave a little differently -- on that w3schools page I saw the borders at first, and they disappeared on hover. After switching tabs, the borders are gone.

I have the same "Failed to create DrawTarget" errors.

Comment 5

[Marko Korhonen]

Yes I have had WR enabled ever since I moved on to Wayland. Is it relevant to test it without WR?

Comment 6

[Darkspirit]

KDE, Wayland, Debian Testing, Intel Iris 6100 (Broadwell GT3)
Confirmed. (It's a Nightly-only pref.) Disabling native theme (bug 1615105) does not help.

$ GDK_BACKEND=wayland mozregression --launch 20200505094621 --pref gfx.webrender.all:true widget.wayland-dmabuf-textures.enabled:true widget.disable-native-theme-for-content:true -a http://www.w3schools.com/html/tryit.asp?filename=tryhtml_input_checkbox -a about:support

(#17) Error Failed to create DrawTarget, Type: 3 Size: Size(1280,33), Data: 0, Stride: 0

$ GDK_BACKEND=wayland mozregression --good 2020-03-03 --bad 2020-03-05 --pref gfx.webrender.all:true widget.wayland-dmabuf-textures.enabled:true -a http://www.w3schools.com/html/tryit.asp?filename=tryhtml_input_checkbox -a about:support

18:49.33 INFO: Last good revision: 5c97a8056cd9fbce27ed3cdd50c6be2f1bd8475e
18:49.33 INFO: First bad revision: bf8c2eefd9b2931f0b449a7a40435dc9cc3879b9
18:49.33 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5c97a8056cd9fbce27ed3cdd50c6be2f1bd8475e&tochange=bf8c2eefd9b2931f0b449a7a40435dc9cc3879b9

bf8c2eefd9b2931f0b449a7a40435dc9cc3879b9 Greg V — Bug 1590832 - fix Wayland dmabuf texture crash and rendering on Radeon r=stransky

Comment 7

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 8

[Marko Korhonen]

This seems to have been resolved in the latest nightly. Can anyone else confirm?

Comment 9

[Laurențiu Nicola]

Yes, I think this is working now (with widget.dmabuf-textures.enabled because the preference was recently renamed).

Can someone please close this as RESOLVED WORKSFORME?