1627707 - LoadInfo::LoadingPrincipal should be GetLoadingPrincipal instead.

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

It can return null, so renaming it like that would prevents mistakes.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb

Mostly a matter of:

rg -l '->LoadingPrincipal' | xargs sed -i 's/->LoadingPrincipal/->GetLoadingPrincipal/g'

And then clang-format. But I tweaked manually nsHttpChannelAuthProvider (move
the variable where it's used, don't take a useless strong ref),
AddonContentPolicy (move the declaration of the variable to the if condition),
and BackgroundUtils (same).

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1627707 - Deindent most of CHECK_PRINCIPAL_CSP_AND_DATA. r=ckerschb

It's just a nested if which can be written with &&.

Depends on D69828

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1627707 - Minor cleanup in LoadInfoToLoadInfoArgs. r=ckerschb

No need for temporaries, we can just construct the object in place.

Depends on D69829

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/058a19e11b06
Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/378ec30d9979
Deindent most of CHECK_PRINCIPAL_CSP_AND_DATA. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/65d6a90651ce
Minor cleanup in LoadInfoToLoadInfoArgs. r=ckerschb

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/403e503a4a84
Backed out 3 changesets for build bustages @ mozilla::net::LoadInfo.

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing several test failures:

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=65d6a90651ce377687e88f93d50a6051bb12a029&failure_classification_id=2&selectedJob=296450468

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=296450468&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296449666&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296450470&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296450532&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296450527&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296449819&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/403e503a4a84

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/711bb3721f0d
Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/1e6c40ef6b87
Deindent most of CHECK_PRINCIPAL_CSP_AND_DATA. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/7044929ad879
Minor cleanup in LoadInfoToLoadInfoArgs. r=ckerschb

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/711bb3721f0d
https://hg.mozilla.org/mozilla-central/rev/1e6c40ef6b87
https://hg.mozilla.org/mozilla-central/rev/7044929ad879

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c5ff52454b8e
Port bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. rs=bustage-fix