1627738 - Expose Graphics Card and Driver info in "Browser Configuration" section of webcompat reports

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, enhancement, P1)

Description

[Mike Taylor [:miketaylr]]

In conjunction with the Hunt for Home campaign, the Graphics team would like a little more info for incoming reports ( to see if they can try to catch some webrender issues).

We already capture "is webrender enabled", but if it is, we'd also like to grab Graphics card and driver info -- the same info that's exposed via about:support.

Open question: what are the privacy implications of gathering this information? Do we need to add a check-mark "Add my graphics card info"? Is it fine to grab by default?

Comment 1

[Mike Taylor [:miketaylr]]

Jessie, can you verify which fields from about:support would be useful here?

Comment 2

[Jessie [:jbonisteel] pls NI]

GPU (sometimes there are two), Active, Description, Vendor and Device ID and Driver Version would be ideal. Output looks like:

GPU #1
Active: Yes
Description: Intel(R) UHD Graphics 630
Vendor ID: 0x8086
Device ID: 0x3e9b
Driver Version: 26.20.100.6860

Comment 3

[Mike Taylor [:miketaylr]]

Had a chat with Lonnen, and he said data about machines should be safe, if we give users the ability to see the info and edit it out before sending. Shouldn't be too hard to implement.

Comment 4

[Thomas Wisniewski [:twisniewski]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bd46ab7341c8bdb93de0b8b7f0ac7dcc749ad32

Comment 5

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1627738 - expose GPU troubleshooting information to webcompat reports; r?gijs,miketaylr

Comment 6

[Mike Taylor [:miketaylr]]

Thanks Tom. I should have been more explicit about requirements here (and thought of everything before asking you to write the patch). Sorry about that.

We only want to grab the GPU info you have here iff:

1. webrender is enabled
2. datareporting.healthreport.uploadEnabled is not set to false

Would you mind reworking the patch to match these assumptions?

Comment 7

[Thomas Wisniewski [:twisniewski]]

Sure, done.

Comment 8

[Mike Taylor [:miketaylr]]

Thanks Tom, let's block on https://github.com/webcompat/webcompat.com/issues/3282 (which should be done tomorrow) before landing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f6192bcfb53
expose GPU troubleshooting information to webcompat reports; r=Gijs,webcompat-reviewers,miketaylr

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1f6192bcfb53