1627763 - Context Menu should launch from center of focused item, not upper left

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Morgan Reschenberg [:morgan]]

We should use x_coord = rect.x + rect.height/2 and y_coord = rect.y + rect.height/2 to get the center coordinate when creating our layout point.

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1627763: Adjust coordinates of layout point for launching context menu.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94fec719ba14
Adjust coordinates of layout point for launching context menu. r=eeejay

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/94fec719ba14

Comment 4

[Marco Zehe (:MarcoZ)]

This bug affects Firefox 76, which got context menu as a new accessibility feature in MacOS. This should be uplifted to beta 76. Morgan, can you request uplift?

Comment 5

[Morgan Reschenberg [:morgan]]

Comment on attachment 9138640 [details]
Bug 1627763: Adjust coordinates of layout point for launching context menu.

Beta/Release Uplift Approval Request

• User impact if declined: VoiceOver users will continue to receive incorrect context menus after performing the "show menu" action.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Navigate to data:text/html,<img alt="Firefox" src="https://www.mozilla.org/media/protocol/img/logos/firefox/logo-word-hor.96f28a0f9ae6.svg" width="125" height="40"><a name="Meet the Family" href="/en-GB/firefox/accounts/" >Meet the Family</a>

2. Enable VoiceOver
3. Enter web content (Opt + CMD + Shift + Down)
4. With cursor on image, launch context menu (CMD + Opt + Shift + M)

Expected: a context menu for an image (ie. Save image, etc.) is launched

5. Hit escape to close current context menu
6. Move to link (CMD + opt + right arrow)
7. Launch context menu on link

Expected: context menu for link (ie. Bookmark link, etc.) is launched

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is not (yet) covered by automated tests, however our the current context menu code is not usable and, though there may be more issues to uncover, this is a substantial improvement for users.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9138640 [details]
Bug 1627763: Adjust coordinates of layout point for launching context menu.

Approved for 76.0b2.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7c1736d2a065

Comment 8

[Cristian Fogel [:cfogel]]

Confirmed issue with 76.0a1 (2020-04-05), verified fix with 76.0b2, 77.0a1 (2020-04-08) on macOS 10.15.3.