1627765 - Stop caching children in mac

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P1)

Description

[Eitan Isaacson [:eeejay]]

Caching children gives us no performance benefit, since it is mostly a simple list access anyway. In e10s it doesn't involve an IPC call, as the hierarchy is already cached in the main process.

Removing the children cache will simplify top-level chrome children since many of them are toggled in and out of visibility with no mutation change event.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1627765 - Rename firePlatformEvent to handleAccessibleEvent. r?morgan

The latter seems more accurate to what that method does, since we don't necessarily
forward that event to the OS, but might instead use it to update cached properties.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1627765 - Use REORDER event to invalidate table column accessibles. r?morgan

We need to do this because we can't rely on the main children cache invalidation.
Also, I don't think this really worked before with cell additions to a row, since only
the row's children would be invalidated, and the table's children would remain untouched.

Depends on D69878

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1627765 - Remove mac heirarchy cache. r?morgan

Depends on D69879

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ab7c3a66d87
Rename firePlatformEvent to handleAccessibleEvent. r=morgan
https://hg.mozilla.org/integration/autoland/rev/3987a054cda9
Use REORDER event to invalidate table column accessibles. r=morgan
https://hg.mozilla.org/integration/autoland/rev/33870350e2bc
Remove mac heirarchy cache. r=morgan

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b2d6d467d0b
Fix lint failure r=fix

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9ab7c3a66d87
https://hg.mozilla.org/mozilla-central/rev/3987a054cda9
https://hg.mozilla.org/mozilla-central/rev/33870350e2bc
https://hg.mozilla.org/mozilla-central/rev/3b2d6d467d0b