1627768 - rust asan fails the check_networking test for getsockname

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[(Away)]

Using nightly-2020-04-04:

TEST-UNEXPECTED-FAIL | check_networking | libgkrust.a | Identified 1 networking function(s) being imported in the rust static library (getsockname)

Comment 1

[Tom Ritter [:tjr]]

At this point, we should probably just remove this check and work on Bug 1620045.

In lieu of removing the check, we can remove the function from the list of functions to check.

It would be good to understand why rust is now including this function though.

Comment 2

[(Away)]

Oh, I just realized that this only happens when I enable asan on rust, so it must be something in the sanitizer runtime. I'm guessing https://github.com/llvm/llvm-project/blob/fad47d222561f0672223b0b3304ff1c739cb3288/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc#L2616-L2630.

I wonder why this wasn't a problem for "regular" (c++) asan? I guess the check_networking only looks at rust things?

Comment 3

[Tom Ritter [:tjr]]

(In reply to :dmajor from comment #2)

I guess the check_networking only looks at rust things?

Correct.

Comment 4

[(Away)]

Maybe we should just turn this bug into "add ifndef MOZ_ASAN", if the bigger rewrite doesn't happen in time.

Comment 5

[(Away)]

decoder pointed out to me that we already have such an ifndef for MOZ_TSAN: https://searchfox.org/mozilla-central/rev/4d2a9d5dc8f0e65807ee66e2b04c64596c643b7a/config/makefiles/rust.mk#303. So asan will be an easy extension of that.

Comment 6

[(Away)]

Attachment: Expand check_networking exemption to ASan and UBSan builds

They all fail for the same reason: the sanitizer runtime in compiler-rt installs an interceptor for getsockname which then contains a call to the real implementation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bf6c841e1d7
Expand check_networking exemption to ASan and UBSan builds r=rstewart

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9bf6c841e1d7