1627848 - Don't send large URI's over IPC with SendVisitURI() if the URI won't be added to history

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Haik Aftandilian [:haik]]

Don't send URI's over IPC to the parent with SendVisitURI() if the URI is too large or the wrong scheme (e.g., data:) to be added to the history. Data URI's or URI's over 2000 bytes are not added to the history so we can avoid unnecessary IPC traffic by checking the scheme and size in the content process first. On bug 1609631, the test case calls FileReader.readAsDataURL() on a PDF file input which triggers a call to SendVisitURI() sending the file contents as a data URI.

Comment 1

[Marco Bonardo [:mak]]

This is a good optimization idea, thanks!

Comment 2

[Haik Aftandilian [:haik]]

Attachment: Bug 1627848 - Don't call SendVisitURI() if the URI won't be added to history r?mak!

Avoid unnecessary IPC traffic by checking if URI's meet the history criteria before sending them to the parent with SendVisitURI.

Comment 3

[Haik Aftandilian [:haik]]

With this fix, I looked into making nsNavHistory::mHistoryEnabled static, set once at startup, but the test toolkit/components/places/tests/browser/browser_visituri_nohistory.js modifies this pref so I did not undertake trying to make nvNavHistory::IsHistoryDisabled() be called in the child.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0483abbea83d
Don't call SendVisitURI() if the URI won't be added to history r=mak

Comment 5

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=RBBCsUYKQzeTmL5VdFB-8Q-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=0483abbea83d442f83363f1cf87659702fd835f7

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299690942&repo=autoland&lineNumber=41448

Backout: https://hg.mozilla.org/integration/autoland/rev/f707e3fa32cb45c899eeceff408c81b906333c60

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9647b3d42c39
Don't call SendVisitURI() if the URI won't be added to history r=mak

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9647b3d42c39