Closed Bug 1627882 Opened 4 years ago Closed 4 years ago

Remove compatibility code in devtools/client/webconsole/utils/messages.js transformPageErrorPacket

Categories

(DevTools :: Console, task, P3)

Product:
DevTools
Component:
Console
Type:
task

Tracking

(firefox77 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: nchevobbe, Assigned: alexsmp)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1627882 - Removed compatibility code in transformPageErrorPacket(). r=nchevobbe!
47 bytes, text/x-phabricator-request
Details | Review

In devtools/client/webconsole/utils/messages.js#340-343, there's this block:

    // Backward compatibility: cssSelectors might not be available when debugging
    // Firefox 67 or older.
    // Remove `|| ""` when Firefox 68 is on the release channel.
    cssSelectors: pageError.cssSelectors || "",

we're now at Firefox 76, so it's safe to turn this into

    cssSelectors: pageError.cssSelectors,

Hi, newbie here, can I take on this task ?

Hello Alex, thanks for helping, the bug is now yours

If it's your first bug, you might want to read this https://docs.firefox-dev.tools/getting-started/ to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :)
Also, you can come and chat on our Slack https://devtools-html-slack.herokuapp.com/

Assignee: nobody → alexsmp
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9dc3d5899699
Removed compatibility code in transformPageErrorPacket(). r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/9dc3d5899699

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.