1627892 - Reduce use of raw pointers in dom/cache

Status: RESOLVED FIXED

(Core :: Storage: Cache API, task, P3)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1627892 - Replace custom AutoLock by BaseAutoLock. r=#dom-workers-and-storage

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1627892 - Make Manager derive from SafeRefCounted. r=#dom-workers-and-storage

Depends on D69945

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1627892 - Make Context derive from SafeRefCounted. r=#dom-workers-and-storage

Depends on D69956

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1627892 - Make InternalRequest derive from SafeRefCounted. r=#dom-workers-and-storage

Depends on D69957

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1627892 - Make StreamList derive from SafeRefCounted. r=#dom-workers-and-storage

Depends on D69958

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1627892 - Make CacheWorkerRef derive from SafeRefCounted. r=#dom-workers-and-storage

Depends on D69959

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1627892 - Make ManagerId derive from SafeRefCounted. r=#dom-workers-and-storage

Depends on D69960

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1627892 - Make ThreadsafeHandle derive from SafeRefCounted. r=#dom-workers-and-storage

Depends on D69961

Comment 9

[Jens Stutte [:jstutte]]

Is this meant to be component "Storage: Cache API" ?

Comment 10

[Simon Giesecke [:sg] [he/him]]

(In reply to Jens Stutte [:jstutte] from comment #9)

Is this meant to be component "Storage: Cache API" ?

As discussed on Slack, yes. I'll submit a bug & patch to fix the moz.build file.

Comment 11

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1627892 - Use SafeRefPtr for Request. r=#dom-workers-and-storage

Depends on D69962

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd4efe76e01e
Replace custom AutoLock by BaseAutoLock. r=ttung
https://hg.mozilla.org/integration/autoland/rev/ed1e4e9212ef
Make Manager derive from SafeRefCounted. r=ttung
https://hg.mozilla.org/integration/autoland/rev/253861767768
Make Context derive from SafeRefCounted. r=dom-workers-and-storage-reviewers,perry
https://hg.mozilla.org/integration/autoland/rev/3366be952ce2
Make InternalRequest derive from SafeRefCounted. r=dom-workers-and-storage-reviewers,perry
https://hg.mozilla.org/integration/autoland/rev/c1672bc9a695
Make StreamList derive from SafeRefCounted. r=dom-workers-and-storage-reviewers,perry
https://hg.mozilla.org/integration/autoland/rev/beaab31d3a22
Make CacheWorkerRef derive from SafeRefCounted. r=dom-workers-and-storage-reviewers,perry
https://hg.mozilla.org/integration/autoland/rev/42ecedc82327
Make ManagerId derive from SafeRefCounted. r=dom-workers-and-storage-reviewers,perry
https://hg.mozilla.org/integration/autoland/rev/7030a8580695
Make ThreadsafeHandle derive from SafeRefCounted. r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/a224abc2539e
Use SafeRefPtr for Request. r=dom-workers-and-storage-reviewers,perry

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bd4efe76e01e
https://hg.mozilla.org/mozilla-central/rev/ed1e4e9212ef
https://hg.mozilla.org/mozilla-central/rev/253861767768
https://hg.mozilla.org/mozilla-central/rev/3366be952ce2
https://hg.mozilla.org/mozilla-central/rev/c1672bc9a695
https://hg.mozilla.org/mozilla-central/rev/beaab31d3a22
https://hg.mozilla.org/mozilla-central/rev/42ecedc82327
https://hg.mozilla.org/mozilla-central/rev/7030a8580695
https://hg.mozilla.org/mozilla-central/rev/a224abc2539e