1627963 - CSP and Fission: ShouldLoad should not rely on requestingContext because it's not available in the parent process

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P2)

Description

[Christoph Kerschbaumer [:ckerschb]]

Since we want to make CSP fully fission compatible we should move away passing requestContext to shoudLoad.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Matt, it seems the requestingContext within the actual CSP code is only used for querying if a script was parserCreated. We could move that bit of information into the loadinfo which brings us closer to CSP handling in the parent.

Just confirming, would you sign off on adding a bool parserCreated to loadinfo? If you agree, then I'll get that patch ready.

Comment 2

[Matt Woodrow (:mattwoodrow)]

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #1)

Matt, it seems the requestingContext within the actual CSP code is only used for querying if a script was parserCreated. We could move that bit of information into the loadinfo which brings us closer to CSP handling in the parent.

Just confirming, would you sign off on adding a bool parserCreated to loadinfo? If you agree, then I'll get that patch ready.

Yes, I think that's the right way to solve this.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1627963: Remove requestContext from CSP shouldload and replace with fission friendly primitives. r=mattwoodrow

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55c37e8a6563
Remove requestContext from CSP shouldload and replace with fission friendly primitives. r=mattwoodrow

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 55c37e8a6563 (bug 1627963) for test_csp_reports.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-windows10-64%2Fdebug-xpcshell-e10s-2%2Cx%28x2%29&fromchange=9e08318148efc28233ef62b6ccb83011c6a1cf43&tochange=b0496779c7cde65032214c2d3905cb7e42148f4f&selectedJob=296922921

Backout link: https://hg.mozilla.org/integration/autoland/rev/b0496779c7cde65032214c2d3905cb7e42148f4f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296922921&repo=autoland&lineNumber=4858

[task 2020-04-09T10:01:08.417Z] 10:01:08     INFO -  TEST-START | dom/security/test/unit/test_csp_reports.js
[task 2020-04-09T10:06:08.422Z] 10:06:08  WARNING -  TEST-UNEXPECTED-TIMEOUT | dom/security/test/unit/test_csp_reports.js | Test timed out
[task 2020-04-09T10:06:08.422Z] 10:06:08     INFO -  TEST-INFO took 300000ms

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Bogdan Tara[:bogdan_tara | bogdant] from comment #5)

[task 2020-04-09T10:01:08.417Z] 10:01:08 INFO - TEST-START | dom/security/test/unit/test_csp_reports.js

Ah, that test calls ShouldLoad directly :-(

I'll update - thanks!

Comment 7

[Chris Peterson [:cpeterson]]

M6

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c95cc5cdca16
Remove requestContext from CSP shouldload and replace with fission friendly primitives. r=mattwoodrow

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c95cc5cdca16