1628043 - Some const-correctness improvements in layout code

Status: RESOLVED FIXED

(Core :: Layout, task, P3)

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1628043 - Have GetFrameForPoint and GetFramesForArea take a const nsIFrame*. r=tnikkel

This allows us to have a single const_cast inside GetFramesForArea, and
avoid several callers of these functions (which, as of bug 1556556,
get a const nsIFrame* from RelativeTo inputs) having to const_cast.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1628043 - Have EnterPresShell and LeavePresShell take const nsIFrame*. r=tnikkel

This is a partial attempt to remove the const_cast in GetFramesForArea.
I had to abandon the larger attempt because propagating the const into
nsDisplayListBuilder::mReferenceFrame is not feasible (since it sets
frame properties for caching purposes during display list building).
However, we might as well land the partial attempt as it still improves
const-correctness.

Depends on D70068

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/315243cedc42
Have GetFrameForPoint and GetFramesForArea take a const nsIFrame*. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/0e8b1e12a459
Have EnterPresShell and LeavePresShell take const nsIFrame*. r=tnikkel

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/315243cedc42
https://hg.mozilla.org/mozilla-central/rev/0e8b1e12a459