Use system integration for notification (libnotify) for flatpak
Categories
(Release Engineering :: Release Automation: Other, defect)
Tracking
(firefox75 wontfix, firefox76 fixed, firefox77 fixed)
People
(Reporter: 5i13ghzt462u, Assigned: b)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0
Steps to reproduce:
Install flatpak from https://flathub.org/apps/details/org.mozilla.firefox
e.g. use https://www.bennish.net/web-notifications.html to trigger a notification
Actual results:
It shows in the top-right corner of the primary screen in an ugly rectangle box.
Expected results:
It should use the proper system integration for notifications. (in my case: GNOME)
(This already works when using Firefox outside of the flatpak.)
Technically, I guess this is a missing library (or patch?), i.e. libnotify, in Firefox. See https://github.com/flathub/org.mozilla.Firefox.BaseApp/issues/3 and https://github.com/flathub/org.mozilla.Firefox.BaseApp/pull/5 for how it may be fixed.
Comment 1•5 years ago
|
||
:c4609174, if you think that's a regression, then could you try to find a regression range in using for example mozregression?
No need to install a dependency, running Firefox after flatpak override --talk-name=org.freedesktop.Notifications org.mozilla.firefox
made it work properly, the link you provided shows native notifications and not the top right version.
So, the configuration just needs --talk-name=org.freedesktop.Notifications
to be added to finish-args
It's not really a regression, respectively no commit introduced it, you bot there.
It's just the packaging.
So yeah, then the permission is missing…
Assignee | ||
Comment 4•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by mtabara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a315c20e1713 enable notifications and mpris for Flatpak, r=mtabara, a=jcristau
Comment 7•5 years ago
|
||
Comment on attachment 9139385 [details]
Bug 1628098 - enable notifications and mpris for Flatpak, r=mtabara, a=jcristau
Beta/Release Uplift Approval Request
- User impact if declined: Addresses some flatpak automation glitch to enable better native notifications.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Non risky. Addresses some flatpak automation glitch to enable better native notifications.
- String changes made/needed:
Updated•5 years ago
|
Comment 8•5 years ago
|
||
bugherder |
Comment 9•5 years ago
|
||
Comment on attachment 9139385 [details]
Bug 1628098 - enable notifications and mpris for Flatpak, r=mtabara, a=jcristau
Flatpak fix, approved for 76.0b5.
Comment 10•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Updated•4 years ago
|
Description
•