1628124 - Do not run the minidump-analyzer when MOZ_CRASHREPORTER_SHUTDOWN is set

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement, P1)

Description

[Gabriele Svelto [:gsvelto]]

As we discussed in person with :tsmith and in bug 1596210 comment 7 and 8 there's no point in running the minidump-analyzer if we already know that the main process is shutting down and it's only causing problems so let's not run it at all.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1628124 - Do not run minidump analysis when we've instructed the browser to shut down after a content process crash r=mconley

When MOZ_CRASHREPORTER_SHUTDOWN is set the main process will shut down as soon
as it detects a content process crash. We usually run the minidump-analyzer
tool for every content process crash but we stop it if we detect we're
shutting down. This is done to prevent hangs because minidump analysis may
take a while.

This patch checks for MOZ_CRASHREPORTER_SHUTDOWN and does not start the
minidump-analyzer at all if it's set. Since we know we'll be shutting down
anyway there's no point in try to run it.

I took the liberty of refactoring some of the surrounding code for better
readability.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ac3889b41cf
Do not run minidump analysis when we've instructed the browser to shut down after a content process crash r=mconley

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2ac3889b41cf