Closed Bug 1628165 Opened 1 year ago Closed 1 year ago

Add telemetry probe for clicks on the vulnerable password learn more notification

Categories

(Firefox :: about:logins, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 77
Tracking Status
firefox75 --- unaffected
firefox76 --- verified
firefox77 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Summary: Add telemetry probe for clicks on the vulnerable password notification → Add telemetry probe for clicks on the vulnerable password learn more notification

This also fixes a bug where we weren't recording the telemetry probe clicks on breached password learn more links due to the refactoring and renaming of the .alert-link class. A test has been added that would have caught that mistake in automation.

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fdddf4601d4d
Add telemetry probe for clicks on vulnerable password learn more link. r=MattN
Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d6fa31b27ba
Add telemetry probe for clicks on vulnerable password learn more link. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

Comment on attachment 9139055 [details]
Bug 1628165 - Add telemetry probe for clicks on vulnerable password learn more link. r?MattN

Beta/Release Uplift Approval Request

  • User impact if declined: Less knowledge about how users are using the new features in Lockwise (about:logins)
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just adding telemetry probes
  • String changes made/needed: none
Attachment #9139055 - Flags: approval-mozilla-beta?

Comment on attachment 9139055 [details]
Bug 1628165 - Add telemetry probe for clicks on vulnerable password learn more link. r?MattN

Adds some new Telemetry probes around an important set of changes shipping in Fx76. Approved for 76.0b6.

Attachment #9139055 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this issue using the latest Firefox Nightly 77.0a1 (Build ID: 20200420214939) and Firefox Beta 76.0b6 (Build ID: 20200420031429) on Windows 10 x64, Mac 10.14, Ubuntu 18.04 x64.

  • A telemetry probe is sent when clicking on the “Learn more” link from the Website Breach/Vulnerable Password notification.
    • For Website Breach the following event is registered: category: pwmgr, method: learn_more_breach, object: existing_login, extra: {"breach": "true"}.
    • For Vulnerable password the following event is registered: category: pwmgr, method: learn_more_vuln, object: existing_login, extra: {"vulnerable": "true"}.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.