1628165 - Add telemetry probe for clicks on the vulnerable password learn more notification

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

For https://searchfox.org/mozilla-central/rev/a707541ff423ade0d81cef6488e6ecfa09273886/browser/components/aboutlogins/content/components/login-item.js#502

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1628165 - Add telemetry probe for clicks on vulnerable password learn more link. r?MattN

This also fixes a bug where we weren't recording the telemetry probe clicks on breached password learn more links due to the refactoring and renaming of the .alert-link class. A test has been added that would have caught that mistake in automation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdddf4601d4d
Add telemetry probe for clicks on vulnerable password learn more link. r=MattN

Comment 3

[Andreea Pavel [:apavel]]

Backed out for build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=9ff15f0fcf970ae82efefa9991ff897f5e9c825c&selectedJob=297993736

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297993736&repo=autoland&lineNumber=3813

Backout: https://hg.mozilla.org/integration/autoland/rev/0d27285d90d7c3d7cdbc4b24e6573af06ca15a51

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d6fa31b27ba
Add telemetry probe for clicks on vulnerable password learn more link. r=MattN

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0d6fa31b27ba

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9139055 [details]
Bug 1628165 - Add telemetry probe for clicks on vulnerable password learn more link. r?MattN

Beta/Release Uplift Approval Request

• User impact if declined: Less knowledge about how users are using the new features in Lockwise (about:logins)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adding telemetry probes
• String changes made/needed: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9139055 [details]
Bug 1628165 - Add telemetry probe for clicks on vulnerable password learn more link. r?MattN

Adds some new Telemetry probes around an important set of changes shipping in Fx76. Approved for 76.0b6.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/78573384584e

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 77.0a1 (Build ID: 20200420214939) and Firefox Beta 76.0b6 (Build ID: 20200420031429) on Windows 10 x64, Mac 10.14, Ubuntu 18.04 x64.

• A telemetry probe is sent when clicking on the “Learn more” link from the Website Breach/Vulnerable Password notification.
  • For Website Breach the following event is registered: category: pwmgr, method: learn_more_breach, object: existing_login, extra: {"breach": "true"}.
  • For Vulnerable password the following event is registered: category: pwmgr, method: learn_more_vuln, object: existing_login, extra: {"vulnerable": "true"}.