1628193 - Matterport 3D tours not working - Firefox only

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[BenMonkey]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:74.0) Gecko/20100101 Firefox/74.0
Firefox for Android

Steps to reproduce:

We produce Matterport 3D virtual tours. Up till now, we have been able to embed the tours on our, and client sites, and they play on-page with no issue.

We have discovered that our spaces, when embedded on a webpage, dont work in Firefox and get a ‘oops, model not available’ error.

They all work if the page is loaded in safari.

We are using this code to embed which has always worked up till now:
<iframe class="embed-responsive-item" src="https://my.matterport.com/show/?m=6By4dFjpWL2&brand=0" width="300" height="150" frameborder="0" allowfullscreen="allowfullscreen"></iframe>

The actual straight URL works in Firefox - just not the embedded ones.

Matterport claim that they wont work if 2 or more are embedded on a page, which seems odd since: - this only just started happening - it doesnt happen in browsers other than firefox - some people (rarely) dont have the issue even in Firefox

Here is an example of a page with the tours embedded, having the issue in Firefox: https://www.unicol.unimelb.edu.au/about-us/gallery/virtual-tours/

I have been told that there is now a limit on the number of tours Firefox will allow on the one page, however in the Firefox community forum, a response was given:
I tested in Firefox 72 and there it works with the same default pref setting. You can consider to file a bug report to see whether this is a regression that should be fixed since this worked in previous Firefox versions.

Actual results:

Matterport tours wont load

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5cbf5bb11c585d69321b420f67ffb62544141427&tochange=e1b0906509efa6433978b9f980ec639b7eafbc6d

Comment 3

[Kelsey Gilbert [:jgilbert]]

On that page there's enough WebGL contexts to trigger our webgl.max-contexts-per-principal limit of 16, which starts killing contexts, from which the page doesn't really recover.
We should raise this limit anyway.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1628193 - Increase max webgl contexts (per principal) to 1000 (300).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d065a4dd4f6
Increase max webgl contexts (per principal) to 1000 (300). r=lsalzman

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1d065a4dd4f6

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9142489 [details]
Bug 1628193 - Increase max webgl contexts (per principal) to 1000 (300).

Beta/Release Uplift Approval Request

• User impact if declined: Default pref update (which we can fix remotely if needed) that helps improve behavior on pages with lots of WebGL canvases, such as Matterport.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk, since this just ups a limit, and we should be able to change prefs without a chemspill if it's a problem
• String changes made/needed: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9142489 [details]
Bug 1628193 - Increase max webgl contexts (per principal) to 1000 (300).

I'm a bit worried about hitting issues in the wild with OOMs and the like with such a large increase in the limit, but at least the pref is remotely flippable if needed. Approved for 76.0b8 to improve webcompat.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/38a78e253f8d

Comment 11

[Peter Magyari (Desktop QA)]

Reproduced the issue on MacOS 10.15 and Windows 10 using Firefox 77.0a1(20200422214848) and Firefox 76.0b7(20200421231527)
Verified the fix on Firefox 77.0a1(20200423214309) and Firefox 76.0b8 (20200424000239)