1628201 - HelperThreadTaskHandler should use UniquePtr for mOffThreadTask

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

HelperThreadTaskHandler use the RunnableTask* passed by HelperThreadTaskCallback()
https://searchfox.org/mozilla-central/rev/a707541ff423ade0d81cef6488e6ecfa09273886/js/xpconnect/src/XPCJSThreadPool.h#27

The ownership of the RunableTask could be forwarded to XPCOM thread pool.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1628201: HelperThreadTaskHandler should use UniquePtr for mOffThreadTask.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/152d46945b27
HelperThreadTaskHandler should use UniquePtr for mOffThreadTask. r=KrisWright

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 152d46945b27 for causing bustages regarding UniquePtr.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b760586ab7e62af195a44bbaa43b01be047c11db

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=676749&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=b760586ab7e62af195a44bbaa43b01be047c11db&fromchange=152d46945b27874ddb2329e4cddeaa8edfe95c69&searchStr=Windows%2C2012%2Cx64%2Cshippable%2Copt%2CProfile-guided%2Coptimization%2Cbuilds%2Cbuild-win64-shippable%2Fopt%2CBpgo%28B%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296970003&repo=autoland&lineNumber=60499

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

lld-link: error: undefined symbol: void (__cdecl *js::HelperThreadTaskCallback)(class mozilla::UniquePtr<struct js::RunnableTask, struct JS::DeletePolicy<struct js::RunnableTask>>)

It looks like for windows,
The definition in JSRuntime.cpp
void (*HelperThreadTaskCallback)(UniquePtr<RunnableTask>);
the parameter UniquePtr, it uses mozilla::UniquePtr instead of js::UniquePtr, will add js:: to fix this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad3f58c996e5
HelperThreadTaskHandler should use UniquePtr for mOffThreadTask. r=KrisWright

Comment 6

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=297151851&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C2012%2Cx64%2Cshippable%2Copt%2Cprofile-guided%2Coptimization%2Cbuilds%2Cbuild-win64-shippable%2Fopt%2Cbpgo%28b%29&revision=ad3f58c996e59bc5ca0a0e6aac61c8f6a7e51096

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297151851&repo=autoland&lineNumber=59822

Backout: https://hg.mozilla.org/integration/autoland/rev/8e0175d2781728592b204b7e564fb18dfdcab40b

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1628201 : Use MOZ_NEVER_INLINE to prevent linking error on windows pgo build.

Filed Bug 1630189 for the weird linking error on windows pgo build and
use MOZ_NEVER_INLINE to prevent it.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

fixed the linking error in my 2nd patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83bb64e5b26d
HelperThreadTaskHandler should use UniquePtr for mOffThreadTask. r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/dd0e24feda2d
Use MOZ_NEVER_INLINE to prevent linking error on windows pgo build. r=dmajor

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/83bb64e5b26d
https://hg.mozilla.org/mozilla-central/rev/dd0e24feda2d