1628208 - 5.88 - 15.09% compiler_metrics num_static_constructors (linux64, linux64-aarch64, linux64-shippable) regression on push 1fc1ef473a68baf6f226176b3afc8a96feb045ed (Tue April 7 2020)

Status: RESOLVED WONTFIX

(Toolkit :: General, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=1fc1ef473a68baf6f226176b3afc8a96feb045ed

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

15% compiler_metrics num_static_constructors linux64 opt valgrind 106.00 -> 122.00
15% compiler_metrics num_static_constructors linux64-shippable opt 106.00 -> 122.00
15% compiler_metrics num_static_constructors linux64 opt 107.00 -> 123.00
15% compiler_metrics num_static_constructors linux64-aarch64 opt 107.00 -> 123.00
15% compiler_metrics num_static_constructors linux64 opt base-toolchains-clang 109.00 -> 125.00
15% compiler_metrics num_static_constructors linux64-shippable opt instrumented 110.00 -> 126.00
13% compiler_metrics num_static_constructors linux64 opt base-toolchains 127.00 -> 143.00
10% compiler_metrics num_static_constructors linux64 debug 158.00 -> 174.00
10% compiler_metrics num_static_constructors linux64 debug gcp 158.00 -> 174.00
10% compiler_metrics num_static_constructors linux64 debug base-toolchains-clang 159.00 -> 175.00
6% compiler_metrics num_static_constructors linux64 debug base-toolchains 272.00 -> 288.00

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=25557

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Comment 1

[Edouard Oger [:eoger]]

I'm not quite sure what we can do here, I've already checked-in the "lite" version of protobuf like we did last time in bug 1411450 :/

Comment 3

[Dão Gottwald [:dao]]

(In reply to Edouard Oger [:eoger] from comment #1)

I'm not quite sure what we can do here, I've already checked-in the "lite" version of protobuf like we did last time in bug 1411450 :/

Does this mean wontfix?

Comment 4

[Edouard Oger [:eoger]]

I think so, unless I'm missing something obvious here.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Edouard Oger [:eoger] from comment #4)

I think so, unless I'm missing something obvious here.

Lina, do you agree with wontfixing this?

Comment 6

[Lina Butler [:lina]]

Yep, I agree!