Perma damp PID 3549 | SyntaxError: missing ) after argument list (✕2)
Categories
(DevTools :: Console, defect, P5)
Tracking
(firefox77 fixed)
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: nchevobbe)
References
(Regression)
Details
(Keywords: intermittent-failure, regression)
Attachments
(1 file)
Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=296641394&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/X3R-NMwSTz-IniAoZ-uBOw/runs/0/artifacts/public/logs/live_backing.log
Since bug 1627687 landed, the damp logs contain 100+ such lines (task still completes successfully):
[task 2020-04-07T16:46:42.791Z] 16:46:42 INFO - PID 3549 | [TEST_LOG] Console output changed - checking content:
[task 2020-04-07T16:46:42.793Z] 16:46:42 INFO - PID 3549 | [TEST_LOG] Still waiting for the following messages:
[task 2020-04-07T16:46:42.793Z] 16:46:42 INFO - PID 3549 | This page uses the non standard property “zoom” (✕3)
[task 2020-04-07T16:46:42.793Z] 16:46:42 INFO - PID 3549 | Layout was forced before the page was fully loaded. (✕1)
[task 2020-04-07T16:46:42.793Z] 16:46:42 INFO - PID 3549 | Some cookies are misusing the “sameSite“ attribute, so it won’t work as expected (✕1)
[task 2020-04-07T16:46:42.793Z] 16:46:42 INFO - PID 3549 | InvalidStateError: XMLHttpRequest state must be OPENED. (✕1)
[task 2020-04-07T16:46:42.793Z] 16:46:42 ERROR - PID 3549 | SyntaxError: missing ) after argument list (✕2)
[task 2020-04-07T16:46:42.793Z] 16:46:42 INFO - PID 3549 | ReferenceError: Bootloaddisableder is not defined (✕4)
[task 2020-04-07T16:46:42.793Z] 16:46:42 INFO - PID 3549 | ---
This prevents the identification of lines which cause the task to fail in the future.
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
Yes, this is a list of expected messages in the console, which we dump from the test to help tracking possible failures in the future.
The line starting with SyntaxError is one of the expected messages. I guess this messes up with how the logs are parsed? Could I add a prefix or something so this line isn't seens as an error?
If not, maybe I can only dump the content after X seconds, so we won't be so spammy when the test passes
|
||
Comment 2•5 years ago
|
||
It gets catched by this Treeherder parser line: https://github.com/mozilla/treeherder/blob/9289f542e8729e5574ef4a566ddc007a4c943085/treeherder/log_parser/parsers.py#L382
|
|
Assignee | |
Comment 3•5 years ago
|
||
okay, so I can probably prefix the lines I dump, and that won't be caught by the parser. Thanks aryx, I'll provide a patch soon.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
The function now only logs the missing messages after 3s, if no other
DOM updates happened.
This will probably result in having no logs if the test is successful,
while still showing the missing messages if the test is failing.
This also allow us to make the logging more correct: since we were
using an every function, we could bail early and not have a correct
view of what messages were missing.
| Comment hidden (Intermittent Failures Robot) |
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
| Comment hidden (Intermittent Failures Robot) |
Description
•