1628309 - Move always-inline bitwise and relational comparison operations into Interpreter.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[André Bargull [:anba]]

Follow-up from https://phabricator.services.mozilla.com/D69799#2120268.

js::BitNot & co. are marked as MOZ_ALWAYS_INLINE, but when called from IC fallback code or from recover instructions we hardly need to use an inlined version.

Comment 1

[André Bargull [:anba]]

(We could probably move most of Interpreter-inl.h into Interpreter.cpp, but this bug will only tackle bitwise and relational comparison operations.)

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1628309 - Part 1: Move always-inlined bitwise operations into Interpreter.cpp. r=jandem!

Moves the always-inline functions into Interpreter.cpp and appends "Operation"
to the function name, similar to how the inlined arithmetic functions are named.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1628309 - Part 2: Move SignExtendOperation into Recover.cpp. r=jandem!

This function is only called from jit/Recover.cpp. Replace it with a directly
inlined version.

Depends on D70184

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1628309 - Part 3: Move always-inlined relational comparison operations into Interpreter.cpp. r=jandem!

Similar to part 1, move the relational comparison operations into Interpreter.cpp.

Depends on D70185

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fef10d2f90b
Part 1: Move always-inlined bitwise operations into Interpreter.cpp. r=jandem
https://hg.mozilla.org/integration/autoland/rev/e5e0ff980687
Part 2: Move SignExtendOperation into Recover.cpp. r=jandem
https://hg.mozilla.org/integration/autoland/rev/fe9ec0f93b28
Part 3: Move always-inlined relational comparison operations into Interpreter.cpp. r=jandem

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8fef10d2f90b
https://hg.mozilla.org/mozilla-central/rev/e5e0ff980687
https://hg.mozilla.org/mozilla-central/rev/fe9ec0f93b28