Closed
Bug 1628371
Opened 5 years ago
Closed 5 years ago
Consider checking whether JS holders are single-zone in nightly builds too
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
Following on from bug 1624810. Olli suggested that the current debug assertions (in CheckHolderIsSingleZone) may not be sufficient, given that if we get this wrong we risk a crash or security vulnerability.
We can make these checks run in nightly builds to get more coverage (and real-world use rather than just tests). If we don't check every time there shouldn't be any performance impact.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
This bug could lead to assertion failures on nightly. There's no impact (yet) to these, other than the crash of course.
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41b9ae09e73c
Check whether JS holders are single-zone in nightly builds too r=mccr8
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•