1628375 - Duplicate separator, spring and spacer appear in customize toolbar dialog

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Ian Neal]

When a user is customising toolbars they can end up with multiple separators, springs and spacers as each one is now given a unique id in the UI.
STR
1/ Use recent SeaMonkey
2/ Customise a toolbar by adding separators, springs and spacers to it.
3/ Select "Restore Default Set"

Expected Result
1/ Unique set of toolbar elements in dialog

Actual Result
1/ Duplicate elements for separators, springs and spacers.

Comment 1

[Ian Neal]

Attachment: Fix customizeToolbar code

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: surplus elements in dialog
Testing completed (on m-c, etc.): 2.53.2
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: Fix customizeToolbar code for 2.57

Same patch but for 2.57 as code has moved from mozilla to comm repo.

Comment 3

[Ian Neal]

Attachment: Fix customizeToolbar code v1.1 for 2.53

Updated comment.

Comment 4

[Ian Neal]

Attachment: Fix customizeToolbar code v1.1 for 2.53

With qrefresh too

Comment 5

[Ian Neal]

Attachment: Fix customizeToolbar code v1.1 for 2.57

Updated comment in code

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9139218 [details] [diff] [review]
Fix customizeToolbar code v1.1 for 2.57

> +    if ((!isSpecialItem(templateNode) && !(templateNode.id in currentItems)) {

One opening bracket too much.

Comment 7

[Ian Neal]

Attachment: Fix customizeToolbar code v1.2 for 2.57

Removed extra (

Comment 8

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 9

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9139215 [details] [diff] [review]
Fix customizeToolbar code v1.1 for 2.53

LGTM

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9145313 [details] [diff] [review]
Fix customizeToolbar code v1.2 for 2.57

LGTM

Comment 11

[Frank-Rainer Grahl (:frg)]

2.53 and 2.57 only.

Comment 12

[Frank-Rainer Grahl (:frg)]

Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/298a170ea918e6335ffbd6ae15b1d1e0d3288c71