1628406 - enable Wayland and X11 as backup for X11 access

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

We should enable Wayland in flatpaks and rely on X11 access only when it really runs
in a X11 session.

Comment 1

[Robert Mader [:rmader]]

Note that the Wayland backend is not yet enabled by default upstream - and won't until flash plugin support is dropped for good later this year.

So AFAIK the flatpak version would need to carry a patch similar to what Fedora does or FF would need to automatically fall back to Wayland if no X11 connection can be established (probably a good idea anyway, for people running a Wayland compositor without XWayland).

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1628406 - enable Wayland along X11 in flatpaks. r=rail

Depends on D70358

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 9139456 [details]
Bug 1628406 - enable Wayland along X11 in flatpaks. r=rail

Beta/Release Uplift Approval Request

• User impact if declined: None, it addressed some flatpak automation glitch
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): None, it addressed some flatpak automation glitch
• String changes made/needed:

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54ef5203e7d4
enable Wayland along X11 in flatpaks. r=rail

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/54ef5203e7d4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9139456 [details]
Bug 1628406 - enable Wayland along X11 in flatpaks. r=rail

Flatpak fix, approved for 76.0b5.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/59dda346b936

Comment 9

[Darkspirit]

Wouldn't this enable Wayland on KDE as well and bring all the horrible regressions (bug 1609115)?
Firefox' wayland backend is so far (bug 1543600) only enabled downstream on Fedora Gnome.

Comment 10

[Darkspirit]

If the decision is to let users of experimental KDE Wayland experience some more KDE-Wayland-caused bugs (as they could simply switch to KDE X11 if they wish less bugs), then this would be all right. Firefox Stable Flatpak just ships something that hasn't been enabled in Nightly yet, but should be enabled soon (bug 1543600).