Open Bug 1628430 Opened 11 months ago Updated 10 months ago

Precache input gamma tables for sRGB to display profile transforms

Categories

(Core :: GFX: Color Management, defect, P3)

Desktop
All
defect

Tracking

()

People

(Reporter: aosmond, Unassigned)

Details

Attachments

(1 file)

The image decoders can access gfxPlatform::GetCMSRGBATransform/etc on any of the decoder threads, and this is a race condition. It is fairly beign in that the only consequence should be a memory leak, but we should fix this.

Blocks: 455077

The image decoder threads and the main thread all may attempt to create
these transforms, but there was no mutex protecting it. As a result, it
may have caused a small memory leak when decoding the first images. Now
we just create them at startup since we will almost always require them.

This also adds precaching support for RGB profiles in order to share the
gamma tables between the RGB, RGBA and BGRA variants of the sRGB to
display profile transform.

I'm repurposing this bug to just do the precaching work and landing the race condition fix with bug 455077 so we can get this in tree sooner.

No longer blocks: 455077
Summary: Avoid race condition when creating sRGB to display profile transforms → Precache input gamma tables for sRGB to display profile transforms
Attachment #9139421 - Attachment description: Bug 1628430 - Avoid race condition when creating sRGB to display profile transforms. → Bug 1628430 - Precache input gamma tables for sRGB to display profile transforms.
Priority: P2 → P3

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Assignee: aosmond → nobody
Severity: normal → S3
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.