1628430 - Precache input gamma tables for sRGB to display profile transforms

Status: NEW

(Core :: Graphics: Color Management, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

The image decoders can access gfxPlatform::GetCMSRGBATransform/etc on any of the decoder threads, and this is a race condition. It is fairly beign in that the only consequence should be a memory leak, but we should fix this.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1628430 - Precache input gamma tables for sRGB to display profile transforms.

The image decoder threads and the main thread all may attempt to create
these transforms, but there was no mutex protecting it. As a result, it
may have caused a small memory leak when decoding the first images. Now
we just create them at startup since we will almost always require them.

This also adds precaching support for RGB profiles in order to share the
gamma tables between the RGB, RGBA and BGRA variants of the sRGB to
display profile transform.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

I'm repurposing this bug to just do the precaching work and landing the race condition fix with bug 455077 so we can get this in tree sooner.

Comment 3

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)