1628485 - Fix debugQA's text editor close

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

STR
1/ Start the text editor
2/ Enter some text
3/ Close the window
4/ Select either Save or Cancel

Expected Result
1/ Prompted to Save or returned to editor

Actual Result
1/ Window just closes

This is the result of the changes from Bug 1341211:
https://hg.mozilla.org/releases/comm-esr60/rev/d361db34419828cf4b29a22b4f88942cf976d665
and
https://hg.mozilla.org/releases/comm-esr60/rev/5406b6f6d665f8dd6aeb48c1d1c39bd7ae173d92

Fix should be fairly simple.

Comment 1

[Ian Neal]

Attachment: Fix onclose call

[Approval Request Comment]
Regression caused by (bug #): 1341211
User impact if declined: trying to close Text Editor doesn't work as it should
Testing completed (on m-c, etc.): 2.53.2
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9139294 [details] [diff] [review]
Fix onclose call

r/a+ 
Async.promiseSpinningly is gone in mozilla-central. but fixing all callsites up needs to be done in a follow-up anyway later.

Has been restored for 2.57 so works there.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cabba8a9207c
Fix debugQA's text editor close. r=frg DONTBUILD