Closed Bug 1628487 Opened 4 months ago Closed 4 months ago

Option 'Proxy DNS when using SOCKS v5' not greyed out despite GPO preventing changes

Categories

(Firefox :: Enterprise Policies, defect, P1)

76 Branch
Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 77
Tracking Status
firefox-esr68 --- verified
firefox75 --- wontfix
firefox76 --- verified
firefox77 --- verified

People

(Reporter: matthias.huijgen, Assigned: mkaply)

References

Details

Attachments

(4 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.132 Safari/537.36 Edg/80.0.361.66

Steps to reproduce:

It seems like Bug 1540584 at first sight, but it is not quite the same.

I reproduced my findings as described below in Firefox 72.0.1 x64, 74.0.1 x64 and 76.0b2 x64 on Windows 10.
Steps:
Set 'Don't allow proxy settings to be changed.' and leave 'Proxy DNS when using SOCKS v5' unticked in the Proxy Settings of the Firefox GPO Administrative Template.
Setting this GPO results in some registry values in HKCU\Software\Policies\Mozilla\Firefox\Proxy (or HKLM), like "Locked"=dword:00000001 and "UseProxyForDNS"=dword:00000000

Actual results:

In Firefox > Options > Connection Settings, the setting 'Proxy DNS when using SOCKS v5' is unchecked (as expected), but not greyed out (not as expected). One can check this option, and then the box gets checked, but also immediately greyed out (and unchangeable). When clicking OK, and then reopening the Connection Settings, the option 'Proxy DNS when using SOCKS v5' is again unchecked and not greyed out. So this is probably a GUI glitch.

Expected results:

I expected the setting 'Proxy DNS when using SOCKS v5' in Firefox > Options > Connection Settings to be greyed out and not changeable.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Enterprise Policies

The GUI of the Proxy Settings of the Firefox Administrative Template for Group Policy.

View of the registry when setting the GPO as described.

Assignee: nobody → mozilla
Status: UNCONFIRMED → NEW
Type: enhancement → defect
Ever confirmed: true
Priority: -- → P1

I'm going to do a quick fix for this and prioritize bug 1557754 so we don't have to do these one offs.

Status: NEW → ASSIGNED
See Also: → 1557754
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/dcf5c51cd81e
Locked Socks V5 shouldn't enable. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

Comment on attachment 9140274 [details]
Bug 1628487 - Locked Socks V5 shouldn't enable. r?mconley

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Enterprise specific lock case
  • User impact if declined: Pref doesn't lock that should be
  • Fix Landed on Version: 77
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only impacts locked prefs (enterprise)
  • String or UUID changes made by this patch:
Attachment #9140274 - Flags: approval-mozilla-esr68?

Comment on attachment 9140274 [details]
Bug 1628487 - Locked Socks V5 shouldn't enable. r?mconley

Beta/Release Uplift Approval Request

  • User impact if declined: Preference doesn't lock correctly.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just a simple lock change for enterprise.
  • String changes made/needed:
Attachment #9140274 - Flags: approval-mozilla-beta?

Comment on attachment 9140274 [details]
Bug 1628487 - Locked Socks V5 shouldn't enable. r?mconley

Simple fix checking the value of a pref when determining enabled/disabled state. Approved for 76.0b8 and 68.8esr.

Attachment #9140274 - Flags: approval-mozilla-esr68?
Attachment #9140274 - Flags: approval-mozilla-esr68+
Attachment #9140274 - Flags: approval-mozilla-beta?
Attachment #9140274 - Flags: approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

It seems this bug might need manual verification. Mike Kaply, could you provide some (more detailed) steps to reproduce, please?

Flags: needinfo?(mozilla)

Sure. Create a policies.json file with:

{
  "policies": {
     "Proxy": {
        "Mode": "manual",
        "UseProxyForDNS": true,
        "Locked": true
     }
  }
}

Put this file in distribution/policies.json

Before the patch, "Proxy DNS for Sock5" was not disabled.

Flags: needinfo?(mozilla)

Thank you, Mike! I have reproduced the issue on a Nightly build without the fix (v77.0a1 from 2020-04-12) and then verified the fix on Nightly v77.0a1 from 2020-04-27 and on RC v76.0 for the beta channel. Fix not yet in the latest ESR v68.7.0esr. NI to myself to verify when possible.

Flags: needinfo?(daniel.bodea)
OS: Unspecified → All
Hardware: Unspecified → Desktop

Also verified on Firefox ESR Candidate v68.8.0esr.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(daniel.bodea)
You need to log in before you can comment on or make changes to this bug.