Option 'Proxy DNS when using SOCKS v5' not greyed out despite GPO preventing changes
Categories
(Firefox :: Enterprise Policies, defect, P1)
Tracking
()
People
(Reporter: matthias.huijgen, Assigned: mkaply)
References
Details
Attachments
(4 files)
34.30 KB,
image/png
|
Details | |
29.02 KB,
image/png
|
Details | |
40.73 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr68+
|
Details | Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.132 Safari/537.36 Edg/80.0.361.66
Steps to reproduce:
It seems like Bug 1540584 at first sight, but it is not quite the same.
I reproduced my findings as described below in Firefox 72.0.1 x64, 74.0.1 x64 and 76.0b2 x64 on Windows 10.
Steps:
Set 'Don't allow proxy settings to be changed.' and leave 'Proxy DNS when using SOCKS v5' unticked in the Proxy Settings of the Firefox GPO Administrative Template.
Setting this GPO results in some registry values in HKCU\Software\Policies\Mozilla\Firefox\Proxy (or HKLM), like "Locked"=dword:00000001 and "UseProxyForDNS"=dword:00000000
Actual results:
In Firefox > Options > Connection Settings, the setting 'Proxy DNS when using SOCKS v5' is unchecked (as expected), but not greyed out (not as expected). One can check this option, and then the box gets checked, but also immediately greyed out (and unchangeable). When clicking OK, and then reopening the Connection Settings, the option 'Proxy DNS when using SOCKS v5' is again unchecked and not greyed out. So this is probably a GUI glitch.
Expected results:
I expected the setting 'Proxy DNS when using SOCKS v5' in Firefox > Options > Connection Settings to be greyed out and not changeable.
Comment 1•5 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Reporter | ||
Comment 2•5 years ago
|
||
The GUI of the Proxy Settings of the Firefox Administrative Template for Group Policy.
Reporter | ||
Comment 3•5 years ago
|
||
View of the registry when setting the GPO as described.
Assignee | ||
Comment 4•5 years ago
|
||
Problem is here:
https://searchfox.org/mozilla-central/source/browser/components/preferences/connection.js#228
Locked value isn't being checked.
Assignee | ||
Comment 5•5 years ago
|
||
I'm going to do a quick fix for this and prioritize bug 1557754 so we don't have to do these one offs.
Assignee | ||
Comment 6•5 years ago
|
||
Comment 8•5 years ago
|
||
bugherder |
Assignee | ||
Comment 9•5 years ago
|
||
Comment on attachment 9140274 [details]
Bug 1628487 - Locked Socks V5 shouldn't enable. r?mconley
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Enterprise specific lock case
- User impact if declined: Pref doesn't lock that should be
- Fix Landed on Version: 77
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Only impacts locked prefs (enterprise)
- String or UUID changes made by this patch:
Assignee | ||
Comment 10•5 years ago
|
||
Comment on attachment 9140274 [details]
Bug 1628487 - Locked Socks V5 shouldn't enable. r?mconley
Beta/Release Uplift Approval Request
- User impact if declined: Preference doesn't lock correctly.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just a simple lock change for enterprise.
- String changes made/needed:
Comment 11•5 years ago
|
||
Comment on attachment 9140274 [details]
Bug 1628487 - Locked Socks V5 shouldn't enable. r?mconley
Simple fix checking the value of a pref when determining enabled/disabled state. Approved for 76.0b8 and 68.8esr.
Comment 12•5 years ago
|
||
bugherder uplift |
Comment 13•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Comment 14•5 years ago
|
||
It seems this bug might need manual verification. Mike Kaply, could you provide some (more detailed) steps to reproduce, please?
Assignee | ||
Comment 15•5 years ago
|
||
Sure. Create a policies.json file with:
{
"policies": {
"Proxy": {
"Mode": "manual",
"UseProxyForDNS": true,
"Locked": true
}
}
}
Put this file in distribution/policies.json
Before the patch, "Proxy DNS for Sock5" was not disabled.
Comment 16•5 years ago
|
||
Thank you, Mike! I have reproduced the issue on a Nightly build without the fix (v77.0a1 from 2020-04-12) and then verified the fix on Nightly v77.0a1 from 2020-04-27 and on RC v76.0 for the beta channel. Fix not yet in the latest ESR v68.7.0esr. NI to myself to verify when possible.
Comment 17•5 years ago
|
||
Also verified on Firefox ESR Candidate v68.8.0esr.
Updated•5 years ago
|
Description
•