1628489 - Code cleanup Preference#privacy

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect, P1)

Description

[Erica Wright [:ewright]]

When writing a patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1625228, I came across some issues in the code and tests of redundancies and typos. I'll clean them up.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1628489 - Clean up test code, and remove redundancies

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee6615fd152a
Clean up test code, and remove redundancies r=johannh

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset ee6615fd152a for causing failures in browser_contentblocking_categories.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5c574b31e200d2e6c3a1b2d4412fa4889cba21e1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=5c574b31e200d2e6c3a1b2d4412fa4889cba21e1&fromchange=c522095c6db2e2c3100c855670b39c7f23feade9&searchStr=%28bc&selectedJob=297603494

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297603494&repo=autoland&lineNumber=5891

Comment 4

[Erica Wright [:ewright]]

Thanks for the NI, I'm looking into this. The new test has caught some interesting behaviour on Windows when changing the default value of ETP prefs. We need to figure this one out before we may change any of those default values.
Turns out this little bit of cleanup might have been rather important :)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ewright, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Erica Wright [:ewright]]

I was misunderstanding some of the code here. This bug is not longer valid.