1628583 - Crash in [@ wl_proxy_marshal | moz_container_get_wl_surface]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Gabriele Svelto [:gsvelto]]

This bug is for crash report bp-58c206c3-256c-48c7-9869-385a20200407.

Top 10 frames of crashing thread:

0 libwayland-client.so.0 wl_proxy_marshal 
1 libxul.so moz_container_get_wl_surface widget/gtk/mozcontainer.cpp:656
2 libxul.so moz_container_get_wl_egl_window widget/gtk/mozcontainer.cpp:684
3 libxul.so mozilla::gl::GLContextEGL::CreateEGLSurfaceForCompositorWidget gfx/gl/GLContextProviderEGL.cpp:324
4 libxul.so mozilla::wr::RenderCompositorEGL::CreateEGLSurface gfx/webrender_bindings/RenderCompositorEGL.cpp:49
5 libxul.so mozilla::wr::RenderCompositorEGL::Resume gfx/webrender_bindings/RenderCompositorEGL.cpp:132
6 libxul.so mozilla::wr::WebRenderAPI::Resume gfx/webrender_bindings/WebRenderAPI.cpp:587
7 libxul.so mozilla::wr::RenderThread::RunEvent gfx/webrender_bindings/RenderThread.cpp:413
8 libxul.so mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void  xpcom/threads/nsThreadUtils.h:1210
9 libxul.so base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:35

Wayland-specifc crash happening on multiple distros. This is a NULL pointer access originating from here.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Should be this one - Bug 1624745.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Ahh I see, this one is for GL backend. Okay, Thanks a lot!

Comment 3

[Gabriele Svelto [:gsvelto]]

Yeah, the top frames are the same but the stack is different.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

I see. When GL backend is used, both Renderer and Compositor threads access to mozcontainer wayland routines so we need some synchronization here.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

This one is also interesting:
https://crash-stats.mozilla.org/report/index/f914ff58-ce12-4d1f-bcd8-2bef10200413

Comment 6

[Gabriele Svelto [:gsvelto]]

Note that because the symbols aren't great there's a few more signatures on crash-stats if you search for moz_container_get_wl_surface. I'm not sure if they're related or not. Either way we should have better symbols soon and the <name omitted> entries should largely go away from the stack traces.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95e25ef5c6e7efd04552c73c6afaf451011770d3

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1628583 [Wayland] Use mutex to access mozcontainer wayland internals, r?jhorak

Mozcontainer is accessed from various threads - Main/Compositor/Renderer - which causes races
when wayland surfaces are created/deleted/updated so we need to control it.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=adc6cd04f1e3203101dc2b6c99b725a09f30b0c5

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/779722364805
[Wayland] Use mutex to access mozcontainer wayland internals, r=jhorak

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/779722364805

Comment 13

[Noemi Erli[:noemi_erli]]

Backed out changeset 779722364805 (Bug 1628583) per request a=backout in https://bugzilla.mozilla.org/show_bug.cgi?id=1632481#c9

https://hg.mozilla.org/mozilla-central/rev/03626342f6e659ac6699a21e30423e2267c1971f

Comment 14

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Backed out changeset 779722364805 (Bug 1628583) per request a=backout

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks. We need to split mozcontained wayland implementation to a different class to make sure we don't mix X11/Wayland calls.

Comment 16

[Cristian Brindusan [:cbrindusan]]

This failed to land due to:
"2 out of 2 hunks ignored -- saving rejects to file widget/gtk/mozcontainer.h.rej
16 out of 16 hunks ignored -- saving rejects to file widget/gtk/mozcontainer.cpp.rej
abort: patch command failed: exited with status 256"

:stransky can you please take a look?

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Sure, thanks.

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f13f2ff2e18c
[Wayland] Use mutex to access mozcontainer wayland internals, r=jhorak

Comment 20

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f13f2ff2e18c

Comment 21

[Keith Cirkel]

Attachment: Backed out changeset 779722364805 (Bug 1628583) per request a=backout