1628641 - Switch to python3 seems to have broken the Compiler database backend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

When I run Spidermonkey's configure with the compiler database backend enabled, with:

CC="clang" \
CXX="clang++" \
/home/ben/code/mozilla-inbound/js/src/configure \
    --enable-debug \
    --disable-optimize \
    --with-ccache \
    --without-intl-api \
    --enable-warnings-as-errors \
    --enable-linker=lld \
    --enable-build-backends=CompileDB,RecursiveMake

I get the following configure error:

  File "/home/ben/code/mozilla-inbound/js/src/../../configure.py", line 181, in <module>
    sys.exit(main(sys.argv))
  File "/home/ben/code/mozilla-inbound/js/src/../../configure.py", line 57, in main
    return config_status(config)
  File "/home/ben/code/mozilla-inbound/js/src/../../configure.py", line 176, in config_status
    return config_status(args=[], **normalize(sanitized_config))
  File "/home/ben/code/mozilla-inbound/python/mozbuild/mozbuild/config_status.py", line 148, in config_status
    the_backend.consume(definitions)
  File "/home/ben/code/mozilla-inbound/python/mozbuild/mozbuild/backend/base.py", line 144, in consume
    self.consume_finished()
  File "/home/ben/code/mozilla-inbound/python/mozbuild/mozbuild/compilation/database.py", line 88, in consume_finished
    for (directory, filename, unified), cmd in self._db.iteritems():
AttributeError: 'collections.OrderedDict' object has no attribute 'iteritems'

It seems iteritems() has been deprecated with Python 3, and the build system now uses Python 3, so that might be it.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1628641: Use OrderedDict.items() in place of Python 2's iteritems; r?firefox-build-system-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/369961f46e1d
Use OrderedDict.items() in place of Python 2's iteritems; r=sylvestre

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/369961f46e1d