1628669 - Cannot remove amazon.com from top sites list

Status: RESOLVED FIXED

(Firefox :: Top Sites, defect, P3)

Description

[Óscar García Amor]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Open new tab, see amazon.com in top sites list, press tree dots, press delete from history

Actual results:

Nothing, the top site remains in same place

Expected results:

The top site must dissapear.

Note: I never use amazon.com because I have my regional amazon.es and cannot understand why amazon.com is in top sites if never enter on it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Mark Banner (:standard8)]

Moving back to new tab page - this is definitely not search related, and until diagnosed it is better to remain in new tab page as that is where the user is having the issue.

Comment 3

[Marco Bonardo [:mak]]

Did you try to "Unpin" it instead? I suspect what you see is a search shortcut (lens magnifier) not an history entry.

Comment 4

[Mark Banner (:standard8)]

Maybe you could also attach a screenshot of the icon + menu if that's not what you see.

Comment 5

[Óscar García Amor]

Attachment: amazon.com menu

Comment 6

[Óscar García Amor]

(In reply to Marco Bonardo [:mak] from comment #3)

Did you try to "Unpin" it instead? I suspect what you see is a search shortcut (lens magnifier) not an history entry.

I cannot unpin because is not pinned. :-(

Comment 7

[Óscar García Amor]

Attachment: amazon.com when press edit

Comment 8

[Marco Bonardo [:mak]]

if you type ^ in the urlbar, do you see amazon.com among the results?

Comment 9

[Óscar García Amor]

(In reply to Marco Bonardo [:mak] from comment #8)

if you type ^ in the urlbar, do you see amazon.com among the results?

No. And don't have amazon as search provider

Comment 10

[Marco Bonardo [:mak]]

Do you clear history on shutdown, or have a very short history?
Sorry for the many questions, just trying to get more data as possible.

Comment 11

[Óscar García Amor]

(In reply to Marco Bonardo [:mak] from comment #10)

Do you clear history on shutdown, or have a very short history?
Sorry for the many questions, just trying to get more data as possible.

No problem. No. I don't clear history and have a lot of history (since 6 months ago).

Comment 12

[Scott [:thecount] Downe]

I was trying to reproduce, and I didn't see anything obvious that was broken.

This is what I tried, and the results. I did these on a fresh profile.

1. On a fresh profile, you see by default an amazon search topsite. This can be dismissed, and isn't in history so it won't have a delete from history option. Working as expected.
2. I tried to get amazon to show up in topsites organically, it wouldn't. I'm not sure what steps are required to trigger that, but I suspect that's related to properly reproducing this bug.
3. I tried adding an amazon.com topsite directly, this created a pin, which if you unpin, it works. (turns back to the search, which is expected) If you dismiss it, it goes away, and so does the amazon search, this is also expected. If you try to remove from history, it does nothing, which is unexpected. Technically, it is not in the history in this case, it's a pin. Removing a pin from history should either remove the pin, or we should remove that option.

Comment 13

[Óscar García Amor]

I can reproduce it. In Arch Linux I do the following:

1. Create a new profile
2. Navigate in some random places like newspapers, google, mozilla...
3. Navigate in amazon.com
4. Navigate in amazon.es
5. Close Firefox
6. Open Firefox, see amazon.com in top sites, press delete from history, icon remains.

I attach the affected new profile.

Comment 14

[Óscar García Amor]

Attachment: affected profile

Comment 15

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 16

[Daniel]

I'm also experiencing this issue in 80.0.1 (64-bit) on Fedora Linux 32. For me it is pinned, and I cannot unpin it. "Delete from history" didn't help, and neither did "Dismiss".

However! When I edited the link and changed the URL, then unpinned it, it went away.

If someone else is experiencing this issue, it would probably be very helpful to know if opening the Edit dialog for the stuck link, not changing the title, URL, or image, but yes clicking Save unsticks it for you.

Comment 17

[Michael]

I can confirm what Daniel wrote:

• Amazon is in the top sites
• I cannot unpin nor remove it
• If I change the URL I can remove it

Firefox 81.0 (64-bit)

Comment 18

[Michael]

Hey. After the Firefox 82.0 (64-bit) Update Amazon is back again.

More over now the "change URL and then remove" trick mentioned by Daniel does not work any more.
That means I am unable to remove Amazon any more.

Comment 21

[japandi]

can I get the opportunity to take a crack at this

Comment 22

[Scott [:thecount] Downe]

I've never experienced this before. Is this even still an issue? It has been 5 years.

Comment 23

[Óscar García Amor]

Yes, it’s still being produced today. In fact, I personally find it really funny because the name icon refers to the regional Amazon site (in my case, the Spanish one), but the link still goes to amazon.com. No matter what you do, there’s no way to get rid of it.

Comment 24

[japandi]

Let me crack it !!! Thank you !! for Outreachy - open-source contribution program

Comment 25

[japandi]

Attachment: Bug 1628669 - Block URL when deleting from history in Top Sites r=mak

Comment 26

[Marco Bonardo [:mak]]

I replied on Phabricator. You found the actual issue, but I think the approach to the solution is not complete, and would require some UX intervention to evaluate how to progress, as I feel like trying to give more control to the user may end up giving less.
I think the matter is closer to the New tab team and a bit out of my reach.

Comment 27

[japandi]

mak, could you help needinfo the right UX/Content person for the string wording on this dialog? I have updated the patch to address the UX concern.

Comment 28

[Marco Bonardo [:mak]]

UX should likely be someone from the New Tab team, turning to Mike to find the right person.

Comment 29

[Scott [:thecount] Downe]

I can reproduce now.

I suspect my issue was I needed to first dismiss the sponsored amazon shortcut.

I'm looking at the patch now.

I did notice while "delete from history" did not work, "dismiss" did. Is that the same thing as what you all are experiencing?

Comment 30

[Óscar García Amor]

(In reply to Scott [:thecount] Downe from comment #29)

I did notice while "delete from history" did not work, "dismiss" did. Is that the same thing as what you all are experiencing?

Yes, at least in my case.

Comment 31

[Scott [:thecount] Downe]

Yes, at least in my case.

Thanks, I think I get it, and why dismiss works but delete from history does not.

And why this patch fixes it.

Comment 32

[Scott [:thecount] Downe]

So "Delete from history" isn't actually deleting it from history for some reason. I think that might be the root issue.

I did a quick test. I forced it from "https://amazon.com" to "https://www.amazon.com", and it started working as intended.

So for some reason the shortcut doesn't match what's in history, so removing it keeps silently failing.

I think I know why, give me a sec.

Comment 33

[Scott [:thecount] Downe]

If you log link.url and searchProvider.url, like this console.log(link.url, searchProvider.url);

Right before this line: https://searchfox.org/firefox-main/source/toolkit/modules/NewTabUtils.sys.mjs#1093

And then on startup, I see this in the logs: "https://www.amazon.com/ https://amazon.com".

So this is the line that causes the url to be changed, and now is no longer removable because it no longer matches the original places url.

Comment 34

[Scott [:thecount] Downe]

one solution might be to store "originalUrl" link.originalUrl = link.url in the block I linked above, and then when we delete the url, check if we have "originalUrl and use that instead"? So something like link.originalUrl || link.url.

Comment 35

[japandi]

(In reply to Scott [:thecount] Downe from comment #34)

one solution might be to store "originalUrl" link.originalUrl = link.url in the block I linked above, and then when we delete the url, check if we have "originalUrl and use that instead"? So something like link.originalUrl || link.url.

With this feedback, do I proceed ? Thank you. and in what way would you suggest I proceed with my patch ?

Comment 36

[Scott [:thecount] Downe]

Yeah, I would look into fixing the root issue, after understanding it. Hopefully my comment is helpful. If not, I am happy to help more.

Then try to prototype a solution and maybe get it into review, and we can go from there.

Comment 37

[japandi]

Hi, I followed your fix - https://phabricator.services.mozilla.com/D292910 - please see here, let me know if you need anymore changes.

Comment 38

[Scott [:thecount] Downe]

I added a couple comments.

It fixes the original issue, so I just have a few questions in the phabricator.

Comment 39

[japandi]

made the fixes as you requested.

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/666e322f706c
https://hg.mozilla.org/integration/autoland/rev/deb6bb278c0e
Block URL when deleting from history in Top Sites r=home-newtab-reviewers,thecount

Comment 41

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/deb6bb278c0e