1628697 - nsTArray::AppendElements(mozilla::Span<const Item> aSpan) should use ActualAlloc

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Simon Giesecke [:sg] [he/him]]

Currently, the overload always uses FallibleAlloc, which seems wrong:

  template <class Item, typename ActualAlloc = Alloc>
  elem_type* AppendElements(mozilla::Span<const Item> aSpan) {
    return AppendElements<Item, FallibleAlloc>(aSpan.Elements(),
                                               aSpan.Length());
  }

This should be changed to

  template <class Item, typename ActualAlloc = Alloc>
  elem_type* AppendElements(mozilla::Span<const Item> aSpan) {
    return AppendElements<Item, ActualAlloc>(aSpan.Elements(),
                                               aSpan.Length());
  }

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628697 - nsTArray::AppendElements(mozilla::Span<const Item> aSpan) should use ActualAlloc. r=#xpcom-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/461171bd07fe
nsTArray::AppendElements(mozilla::Span<const Item> aSpan) should use ActualAlloc. r=xpcom-reviewers,erahm

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/461171bd07fe