Closed Bug 1628730 Opened 5 years ago Closed 5 years ago

webrtc/simulcast/basic.https.html ini file needs bug number

Categories

(Core :: WebRTC: Signaling, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- fixed

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(1 file)

Looks like the relative path on the script element is not working correctly:

<script src="../third_party/sdp/sdp.js"></script>

Test is in testing/web-platform/tests/webrtc/simulcast
sdp.js is in testing/web-platform/tests/webrtc/third_party/sdp/sdp.js

Looks like a harness issue?

Path should probably be /webrtc/third_party/sdp/sdp.js instead.

Assignee: nobody → docfaraday

beware, this is going to result in a merge conflict since I had to add a "long" meta tag in Chrome to unflake the tests (plus there is a new getStats.https.html in the directory)
Also is it just "../third_party" that is an issue but not ../RTCPeerConnection-helper.js?

../RTCPeerConnection-helper.js seems to work. Maybe the harness has changed, and fixed the pathing issue with sdp.js in the meantime? Let me check that.

there are a couple of other tests that have been around for a while that use a similar approach, e.g. https://wpt.live/webrtc/protocol/msid-parse.html so i'd be surprised if that was a regression

Looks like, for whatever reason, the path is not an issue anymore.

Attachment #9146167 - Attachment description: Bug 1628730: Fix path, and update the ini file to point at the next bug that needs fixing. r?jib → Bug 1628730: Update the ini file to point at the next bug that needs fixing. r?jib
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/862e99e19379 Update the ini file to point at the next bug that needs fixing. r=jib
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78

The patch landed in nightly and beta is affected.
:bwc, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(docfaraday)
Flags: needinfo?(docfaraday)
Summary: webrtc/simulcast/basic.https.html wpt fails because SDPUtils is not being pulled in → webrtc/simulcast/basic.https.html ini file needs bug number
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: