1628732 - Perma [tier2] browser/base/content/test/protectionsUI/browser_protectionsUI_cookies_subview.js | No contentBlockingEvent events should be received - Got 1, expected undefined

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=296967064&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/e8BgDbplQGO_dvuFrixEdQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-04-09T13:50:29.187Z] 13:50:29 INFO - TEST-PASS | browser/base/content/test/protectionsUI/browser_protectionsUI_cookies_subview.js | Main view was shown -
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - Console message: [JavaScript Warning: "Request to access cookie or storage on “https://test1.example.org/browser/browser/base/content/test/protectionsUI/cookieServer.sjs” was blocked because we are blocking all third-party storage access requests and content blocking is enabled."]
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - Console message: [JavaScript Warning: "Request to access cookie or storage on “https://test1.example.org/browser/browser/base/content/test/protectionsUI/cookieServer.sjs” was blocked because we are blocking all third-party storage access requests and content blocking is enabled."]
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - Buffered messages logged at 13:50:29
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - Console message: [JavaScript Warning: "Request to access cookie or storage on “https://test1.example.org/browser/browser/base/content/test/protectionsUI/cookieServer.sjs” was blocked because we are blocking all third-party storage access requests and content blocking is enabled."]
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - Console message: [JavaScript Error: "The character encoding of the plain text document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the file needs to be declared in the transfer protocol or file needs to use a byte order mark as an encoding signature." {file: "https://test1.example.org/browser/browser/base/content/test/protectionsUI/cookieServer.sjs" line: 0}]
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - Received onContentBlockingEvent event: 2147786880 (1 of 1)
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - Buffered messages finished
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/protectionsUI/browser_protectionsUI_cookies_subview.js | No contentBlockingEvent events should be received - Got 1, expected undefined
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - Stack trace:
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - chrome://mochitests/content/browser/browser/base/content/test/protectionsUI/browser_protectionsUI_cookies_subview.js:assertSitesListed:160
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - chrome://mochitests/content/browser/browser/base/content/test/protectionsUI/browser_protectionsUI_cookies_subview.js:testCookiesSubView:268
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-04-09T13:50:29.188Z] 13:50:29 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-04-09T13:50:29.189Z] 13:50:29 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-04-09T13:50:29.189Z] 13:50:29 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-04-09T13:50:29.355Z] 13:50:29 INFO - TEST-PASS | browser/base/content/test/protectionsUI/browser_protectionsUI_cookies_subview.js | Cookies view was shown -

Comment 1

[Johann Hofmann [:johannh]]

Dimi, Tim, we've been getting a bunch of Fission perma failure bugs filed for anti-tracking tests (also bug 1628501 and bug 1628514). I suspect this is related to your work, can you take a look? :)

Thanks!

Comment 2

[Dimi Lee [:dimi]]

I'll check those bugs.

Comment 4

[Cosmin Sabou [:CosminS]]

Th link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&tochange=2ac3fbcc01d49ce2f6960396bb17462cc1c851b5&fromchange=b40b0c09c1fe35923170a106eee15c771cb0245f&test_paths=browser%2Fbase%2Fcontent%2Ftest%2Fprotectionsui%2F&searchStr=fiss&selectedJob=297258474

Comment 5

[Intermittent Failures Robot]

20 failures in 4823 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 20

Platform breakdown:

• windows10-64-qr: 11
• windows10-64: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1628732&startday=2020-04-06&endday=2020-04-12&tree=all

Comment 6

[Dimi Lee [:dimi]]

I haven't figured out the root case.
This seems to only happen in windows opt build. This is quite strange based on what we've changed.
For some reason, in the windows build, it triggers additional anti-tracking checks and generates a content blocking event, which we don't expect receiving that in the test case[1].
Before Bug 1624552, this additional event was not notified because we couldn't get the top-level window, however, after Bug 1624552, getting the top-level window is no longer necessary, hence the event was notified.
I kind of feel that this is happening because we are doing the right thing now, but I am not sure, will keep investigate.

[1] https://searchfox.org/mozilla-central/rev/2cd2d511c0d94a34fb7fa3b746f54170ee759e35/browser/base/content/test/protectionsUI/browser_protectionsUI_cookies_subview.js#160

Comment 7

[Intermittent Failures Robot]

51 failures in 4528 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #23 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 42
• try: 9

Platform breakdown:

• windows10-64-qr: 25
• windows10-64: 26

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1628732&startday=2020-04-13&endday=2020-04-19&tree=all

Comment 8

[Dimi Lee [:dimi]]

just an update that the additional request mentioned in Comment 6 is triggered by ImageCache code here with uri set to chrome://global/skin/icons/resizer.svg
I'll check what is the better solution for this (either fixed in testcase or in anti-tracking code).

Comment 9

[Intermittent Failures Robot]

20 failures in 1125 pushes (0.018 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 12
• try: 8

Platform breakdown:

• windows10-64: 10
• windows10-64-qr: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1628732&startday=2020-04-24&endday=2020-04-24&tree=all

Comment 10

[Intermittent Failures Robot]

70 failures in 5582 pushes (0.013 failures/push) were associated with this bug in the last 7 days.

This is the #28 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 48
• try: 22

Platform breakdown:

• windows10-64: 35
• windows10-64-qr: 35

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1628732&startday=2020-04-20&endday=2020-04-26&tree=all

Comment 11

[Dimi Lee [:dimi]]

Attachment: Bug 1628732 1628501 - disable antitracking mochtiests that fail permanently on window64 opt

Following tests are disabled

• browser_protectionsUI_cookies_subview.js
• browser_protectionsUI_state.js
• browser_allowListNotifications.js
• browser_urlDecorationStripping.js

The reason that this tests are failing in fission mode is because in
window64 opt mode, additional content blocking event is triggered when
loading chrome:://global/skin/icons/resizer.svg

We don't have this problem before because in this case, we couldn't get the
top-level window, so the event was not fired.
But the recent working to make anti-tracking fission compatible (Bug 1624552) removes
the need of getting top-level window, so the event is fired and
testcases don't expect that.

Comment 12

[Tim Huang[:timhuang]]

Obviously, this content blocking event is triggered when loading a chrome resource. Does it make sense to trigger blocking events for chrome resources? Maybe we can filter out this and not notify an event in this case.

Comment 13

[Dimi Lee [:dimi]]

(In reply to Tim Huang[:timhuang] from comment #12)

Obviously, this content blocking event is triggered when loading a chrome resource. Does it make sense to trigger blocking events for chrome resources? Maybe we can filter out this and not notify an event in this case.

Yes, I think that is one of the possible solution we can do.
I have test this
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4219f846d8d049e00baa0f3ca188af6e405138e3
2 out of the 4 testcases can be fixed by the way you suggested, and then I found out there are still 2 testcases needed to be fixed.
I haven't checked what the root cause for the other two, I'll check it and see what is the best solution.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65b2d0679b0f
1628501 - disable antitracking mochtiests that fail permanently on window64 opt r=timhuang

Comment 15

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/65b2d0679b0f

Comment 16

[Intermittent Failures Robot]

8 failures in 5423 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2
• try: 6

Platform breakdown:

• windows10-64: 4
• windows10-64-qr: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1628732&startday=2020-04-27&endday=2020-05-03&tree=all

Comment 17

[Dimi Lee [:dimi]]

Attachment: Bug 1628732 - Don't notify block decision when uri is chrome r=timhuang

Comment 18

[Intermittent Failures Robot]

4 failures in 5276 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 4

Platform breakdown:

• windows10-64: 2
• windows10-64-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1628732&startday=2020-05-04&endday=2020-05-10&tree=all

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/479f86afa10a
Don't notify block decision when uri is chrome r=timhuang,baku

Comment 20

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/479f86afa10a

Comment 21

[Dimi Lee [:dimi]]

no failure with the correct fix, close this bug