1628734 - Collect Telemetry on how long it takes to initialize PSM / NSS from Necko

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

Just as it says on the tin.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Here's a profile from the 2017 reference device showing a ~1s hang in the parent process initializing PSM / NSS: https://perfht.ml/2RsduGt

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1628734 - Add a AutoScalarTimer RAII helper to Telemetry library. r?chutten!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1628734 - Record the time to initialize the NSS component as a scalar. r?keeler!,data-review=chutten

Depends on D70440

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Data review form

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1628734 - Record the time to load certificates off of the main-thread as a scalar. r?keeler!,data-review=chutten

Depends on D70441

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Data review form

Comment 7

[Chris H-C :chutten]

Comment on attachment 9140204 [details]
Data review form

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Mike Conley is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48613e802ca6
Add a AutoScalarTimer RAII helper to Telemetry library. r=chutten
https://hg.mozilla.org/integration/autoland/rev/4619e96bf52e
Record the time to initialize the NSS component as a scalar. r=keeler,data-review=chutten
https://hg.mozilla.org/integration/autoland/rev/cba7768b1b6b
Record the time to load certificates off of the main-thread as a scalar. r=keeler,data-review=chutten

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/48613e802ca6
https://hg.mozilla.org/mozilla-central/rev/4619e96bf52e
https://hg.mozilla.org/mozilla-central/rev/cba7768b1b6b