1628754 - Update cbindgen to 0.14

Status: RESOLVED FIXED

(Core :: General, task, P3)

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: CBindGen update to 0.14.1

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e60ce7274c9f
Cbindgen update to 0.14.0 r=kats

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset e60ce7274c9f for causing bustages in ServoStyleConsts.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/b21b9142dcbf850c201002672ab5cd24b2a4701e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=676749&resultStatus=testfailed%2Cbusted%2Cexception&tochange=b21b9142dcbf850c201002672ab5cd24b2a4701e&fromchange=e60ce7274c9f63edee17f167dfb55b2d438eb689&failure_classification_id=2&selectedJob=297060952

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297060952&repo=autoland&lineNumber=23778

Comment 4

[Dzmitry Malyshau [:kvark]]

Alexandru, are you sure that's caused by my change? The try had similar builds that went OK: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f76e484951034220f6df74250b54f3490da9d7f

Comment 5

[Alexandru Michis [:malexandru]]

I believe so, the builds that failed on autoland are slightly different than the builds that ran on the try push you linked:
https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=676749&tochange=b21b9142dcbf850c201002672ab5cd24b2a4701e&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2C%28bb%29&fromchange=c4fa7454aab6ebfc74c8ca92a0a27545b248c232&selectedJob=297060952

Comment 6

[Dzmitry Malyshau [:kvark]]

Yeah, I think you are correct, Alexandru!

Emilio, you might have ideas about which of the changes regressed Servo. No worries if you are busy, I'll keep looking nevertheless.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

So this is:

    bool operator==(const StyleGenericCalcNode& other) const {                                                                                                                                                                                
      if (tag != other.tag) {                                                      
        return false;                                                              
      }                                                                            
      switch (tag) {                                                               
        case Tag::Leaf: return leaf == other.leaf;                                 
        case Tag::Sum: return sum == other.sum;                                    
        case Tag::MinMax: return min_max == other.min_max;                         
        case Tag::Clamp: return clamp == other.clamp;                              
                                                                                   
      }                                                                            
    }

Which with 0.13 it generates:

  bool operator==(const StyleGenericCalcNode& other) const {
    if (tag != other.tag) {
      return false;
    }
    switch (tag) {
      case Tag::Leaf: return leaf == other.leaf;
      case Tag::Sum: return sum == other.sum;
      case Tag::MinMax: return min_max == other.min_max;
      case Tag::Clamp: return clamp == other.clamp;
      default: return true;
    }
  }

So this broke it, basically: https://github.com/eqrion/cbindgen/pull/475

We can generate a return statement outside of the switch to work around it I guess.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

https://github.com/eqrion/cbindgen/pull/509. Will try to get it released today.

Comment 9

[Landry Breuil (:gaston)]

Fwiw, i had a thunderbird 76.0b1 build failure when testing cbindgen 0.14.0. Is the beta branch supposed to build with this newer cbindgen version ?

Reverting back to 0.13.1 seems to help so far. Will test upcoming release.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=97de7e703a44a247014159b828689354bcde980c looks green.

:gaston it should work with cbindgen 0.14.1 which I'll release today.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/111fd9902e83
CBindGen update to 0.14.1 r=emilio,kats

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/111fd9902e83

Comment 13

[Landry Breuil (:gaston)]

Can confirm that tb 76.0b1 builds with cbindgen 0.14.1, thanks!