1628771 - ALT+S doesn't focus address bar in Firefox with German localization

Status: RESOLVED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[tt_1]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

I recently installed firefox-75.0 on two different computers

Actual results:

this made me loose some of my keyboard shortcuts:

affected are: Alt + S , used to toogle the url bar (it's the same as Alt + D in en_US)

to be continued

Expected results:

Alt + S now does nothing, while Alt + D on en_US is still working as before.

Comment 1

[Francesco Lodolo [:flod]]

Which version of Firefox were you using before updating?

As far as I know, only ALT+D was ever supported on Linux. Does ALT+D work?

Comment 2

[tt_1]

That's correct, I'm a linux user.

I'm mostly using firefox-68.x esr build, which is unaffected; I noticed this on a seperate install which acts as a tinderbox for me to regulary test new compiler snapshots against latest firefox to keep track of breakages.

To answer your question, I upgraded from v74.0.1, but also deleted the profile to test if it's due to that.

ALT + D still works with en_US
ALT + S stopped working with de_DE

Comment 3

[Francesco Lodolo [:flod]]

(In reply to tt_1 from comment #2)

ALT + D still works with en_US XX
ALT + S stopped working with de_DE

As said, what about ALT + D on de_DE?

I'm not sure what caused ALT + S to work in the first place for German. If ALT + D works, I think this would be a wontfix.

Comment 4

[tt_1]

they mean the same on each of the langpacks!

ALT +D does toggle the url bar for en_US, this one is still working with firefox-75.0
ALT + S does the same for de_DE, this one is broken with firefox-75.0

ALT + D makes you open the first drop down menue in the very left corner if you're on de_DE

Comment 5

[Francesco Lodolo [:flod]]

Looks like the issue with ALT+D was reported in bug 1628771.

The string hasn't changed in the German localization, so something else was changed in the code
https://hg.mozilla.org/l10n-central/de/file/default/browser/chrome/browser/browser.dtd#l496

Comment 6

[Francesco Lodolo [:flod]]

OK, found the change.
https://hg.mozilla.org/l10n-central/de/file/default/browser/browser/browserSets.ftl#l19

I moved back to D when we migrated to Fluent, since there are checks running to make sure locales don't change shortcuts unless it's strictly necessary. I assume this would be an exception, and we should restore the previous behavior.

The fix is going to ship in 76, although the questions in bug 1628771 remain (I think it's a terrible idea to have an ALT shortcut for this).

Comment 7

[tt_1]

So, you're going to revert to Alt + S for de_DE with firefox-76.0? If so, is there a way to test this for me?

Comment 8

[Francesco Lodolo [:flod]]

(In reply to tt_1 from comment #7)

So, you're going to revert to Alt + S for de_DE with firefox-76.0? If so, is there a way to test this for me?

Yes. You should be able to test tomorrow with Nightly, or next week with Beta.

Comment 9

[tt_1]

Ok, so I'm just going to wait for firefox-76.0_beta3 then and confirm next week.

I'll be glad if you could point me to the url with the actuall changes though, given how much I'm not familiar with the workflow for the langpacks I might never find it on my own, deep in the hg.

Comment 10

[Francesco Lodolo [:flod]]

The fix landed here
https://hg.mozilla.org/l10n-central/de/rev/ae30b8c2f6d2a9ff90874a0d146525c9dd2ee08d

There should be nothing to do on your side, besides installing the beta version.

Comment 11

[tt_1]

I can confirm this to be fixed in firefox-76.0b3, thank you very much for the fix, it means a lot to me.