1628784 - ./mach jsapi-tests crashes in testBinASTReaderContextECMAScript2

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Tried running ./mach jsapi-tests and got the following failure

testBinASTReaderContextECMAScript2
runTestFromPath: entering directory 'jsapi-tests/binast/parser/context/'
Hit MOZ_CRASH(Couldn't open directory) at /home/matthew/unified/js/src/jsapi-tests/testBinASTReader.cpp:183

Comment 1

[Nicolas B. Pierron [:nbp]]

Could this be that the test case expect to be running in a given directory, that the mach command does not respect?

Comment 2

[Jason Orendorff [:jorendorff]]

mach is running it from the wrong directory. The BinAST tests have to run from $SRCDIR/js/src. It's not good.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Yeah, that's not good. I haven't found a better way to make it work, but if anybody has ideas, I'm interested.

Comment 4

[Tooru Fujisawa [:arai]]

to avoid depending on cwd, one option is to refer env var like TOPSRCDIR.
for automation, we can specify it in autospider.py
for local run, we could either, abort if it's not specified, or maybe fallback to some common cwds.

Comment 5

[Jason Orendorff [:jorendorff]]

(In reply to David Teller [:Yoric] (please use "needinfo") from comment #3)

Yeah, that's not good. I haven't found a better way to make it work, but if anybody has ideas, I'm interested.

Hmm. I imagine C++ __FILE__ is useless because it's relative?

The code under test here is largely generated C++; what if the code-generator spat the absolute path to the test directory into the C++ code somewhere? Then there could be a function in jsfriendapi.h to get that path.

Comment 6

[Tooru Fujisawa [:arai]]

looks like, we have topsrcdir macro defined by command line parameter while compiling, that points js/src with absolute path.
I'll use it.

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1628784 - Pass TOPSRCDIR environment variable to jsapi-tests, in order to read test files. r?Yoric!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31ed49b0ce77
Pass TOPSRCDIR environment variable to jsapi-tests, in order to read test files. r=Yoric

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/31ed49b0ce77