1628793 - [Wayland] Fedora 32 crashes during popup resize

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Attachment: popup which fails to resize & causes crashes

Popup fails to be resized by Firefox on Fedora 32, resize works ok on Fedora 31.
Tested on latest nightly.

Reproduction steps:

1. launch latest nightly on Fedora 32 / Wayland
2. go to https://bluejeans.com/111/webrtc
3. see popup with camera/mic permissions. It's resized so the allow/disallow buttons are hidden. The popup can't be closed.

When this popup is active and I click to hamburger menu or try to create another popup (menu for instance), gnome-shell crashes.

I don't see any of the symptom (failed resize/crash) on Fedora 31 with the same ff version (latest nightly).

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Robert, any idea here?
I'm checking a patch from https://phabricator.services.mozilla.com/D67810 but I guess mutter should not crash in any case. I can reproduce it with mutter-3.36.1-4.fc32.x86_64.
Thanks.

Comment 2

[Robert Mader [:rmader]]

(In reply to Martin Stránský [:stransky] from comment #1)

Robert, any idea here?
I'm checking a patch from https://phabricator.services.mozilla.com/D67810 but I guess mutter should not crash in any case. I can reproduce it with mutter-3.36.1-4.fc32.x86_64.
Thanks.

Will have a look later today - a crash is indeed a Mutter bug, will file an issue as soon as I can reproduce.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Thanks a lot. I checked the patch from https://phabricator.services.mozilla.com/D67810 but it doesn't help with the resize issue.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

I don't see the resize bug in Firefox 75 binary so it may be a regression. Will look at it.

Comment 5

[Robert Mader [:rmader]]

Hm I can't reproduce with build 20200409095500 - the popup gets resized properly. Opening the hamburger menu at the same time does not work however - I get the message gnome-shell[1846]: Buggy client caused popup to be placed outside of parent window.

That being said, I'm on GTK master and there was quite a bit of popup/resize related work going on over the last days:

https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1606
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1638
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1637
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1640
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1650

These have not hit the fedora 32 yet, but will soon.

Anyhow, do you have a backtrace of the crash? Maybe I can find something there.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Ahh okay, I'll wait for the gtk3 update. Any idea which gtk3 version that should be?

That's the GS crash here:
Stack trace of thread 2171:
#0 0x00007f1b282a1584 meta_window_get_frame_rect (libmutter-6.so.0 + 0xde584)
#1 0x00007f1b282fb371 meta_wayland_xdg_positioner_to_placement (libmutter-6.so.0 + 0x138371)
#2 0x00007f1b282fd68d xdg_surface_constructor_get_popup (libmutter-6.so.0 + 0x13a68d)
#3 0x00007f1b27484af0 ffi_call_unix64 (libffi.so.6 + 0x6af0)
#4 0x00007f1b274842ab ffi_call (libffi.so.6 + 0x62ab)
#5 0x00007f1b27c2dcd2 wl_closure_invoke (libwayland-server.so.0 + 0xdcd2)
#6 0x00007f1b27c29132 wl_client_connection_data (libwayland-server.so.0 + 0x9132)
#7 0x00007f1b27c2bbea wl_event_loop_dispatch (libwayland-server.so.0 + 0xbbea)
#8 0x00007f1b282dd0bb wayland_event_source_dispatch (libmutter-6.so.0 + 0x11a0bb)
#9 0x00007f1b28fda76f g_main_dispatch (libglib-2.0.so.0 + 0x5276f)
#10 0x00007f1b28fdaaf8 g_main_context_iterate (libglib-2.0.so.0 + 0x52af8)
#11 0x00007f1b28fdae0b g_main_loop_run (libglib-2.0.so.0 + 0x52e0b)
#12 0x00007f1b2828f3e0 meta_run (libmutter-6.so.0 + 0xcc3e0)
#13 0x00005621de979c9c main (gnome-shell + 0x2c9c)
#14 0x00007f1b2801e042 __libc_start_main (libc.so.6 + 0x27042)
#15 0x00005621de979e7e _start (gnome-shell + 0x2e7e)

Comment 7

[Martin Stránský [:stransky] (ni? me)]

I have gtk3-3.24.17-1.fc32.x86_64 and mutter-3.36.1-4.fc32.x86_64

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: backtrace from ABRT

There's a backtrace from ABRT tool attached.
Thanks.

Comment 9

[Robert Mader [:rmader]]

Hm, somehow the parent surface does not have window associated - filed https://gitlab.gnome.org/GNOME/mutter/-/issues/1174 for it.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

The popup resize is fixed by gtk3-3.24.18-1.fc32.x86_64.

The crash is still reproducible when I click to hamburger menu while bluejeans popup is opened.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Let's move it at https://gitlab.gnome.org/GNOME/mutter/-/issues/1174

Comment 12

[Robert Mader [:rmader]]

FTR: while it was a Mutter bug to crash here, it was likely also a client bug to call get_popup on a apparently already unmapped window. So with the Mutter fix (1) this will crash FF / the clients in the future. But I've personally never seen this anyway.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1408

Comment 13

[Robert Mader [:rmader]]

FTR: While the shell crash has now been fixed in https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1408, this can still crash Firefox if it wasn't fixed by now - Mutter will now send a protocol error instead of crash.

Oh, reopening this was by mistake - however, it might make sense to confirm whether it still happens.

Comment 14

[Robert Mader [:rmader]]

The remaining popup related crashes will hopefully go away in bug 1648698

Comment 15

[Martin Stránský [:stransky] (ni? me)]

I haven't seen that for some time so let's close it for now.