1628886 - Crash in [@ core::result::unwrap_failed]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Dragana Damjanovic [:dragana]]

This bug is for crash report bp-589682e0-9e35-4095-b622-c194c0200409.

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn ../f3e1a954d2ead4e2fc197c7da7d71e6c61bad196/src/libcore/ops/function.rs:232
3 xul.dll std::panicking::rust_panic_with_hook ../f3e1a954d2ead4e2fc197c7da7d71e6c61bad196//src/libstd/panicking.rs:475
4 xul.dll std::panicking::begin_panic_handler ../f3e1a954d2ead4e2fc197c7da7d71e6c61bad196//src/libstd/panicking.rs:375
5 xul.dll core::panicking::panic_fmt ../f3e1a954d2ead4e2fc197c7da7d71e6c61bad196//src/libcore/panicking.rs:84
6 xul.dll core::result::unwrap_failed ../f3e1a954d2ead4e2fc197c7da7d71e6c61bad196//src/libcore/result.rs:1188
7 xul.dll neqo_qpack::encoder::QPackEncoder::encode_header_block third_party/rust/neqo-qpack/src/encoder.rs
8 xul.dll neqo_http3::transaction_client::{{impl}}::send third_party/rust/neqo-http3/src/transaction_client.rs:252
9 xul.dll neqo_http3::connection_client::Http3Client::process_http3 third_party/rust/neqo-http3/src/connection_client.rs:281

Comment 1

[Pascal Chevrel (relman team) -> :pascalc]

That crash is spiking on nightly 77 since build 20200409095500
Changelog for the build: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=acc1632e35c7afc826d16bea8e1dd812b4f5117c&tochange=33d2485721c6ffd20a952d698754041a14be11b3

Comment 2

[Dragana Damjanovic [:dragana]]

The stack is a bit broken. raw crash shows this text: "we should have the entry" therefore the crash happens at:
https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/third_party/rust/neqo-qpack/src/table.rs#174

or maybe here (very unlikely): https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/third_party/rust/neqo-qpack/src/table.rs#174

qpack table size is set to 0 so we should not enter that function at all because we are not adding anything to dynamic table. Maybe we have a problem with setting the capacity when we receive settings from peer (I think i is unlikely.)

Comment 3

[Dragana Damjanovic [:dragana]]

Just a note: this has been fixed in neqo already, we just need to merge neqo into m.-c.