1628892 - Make sync engines bridged via golden_gate report reconciliation count in the sync ping.

Status: RESOLVED WONTFIX

(Firefox :: Sync, enhancement, P3)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

Update: Currently we have almost the whole ping except for the reconciliation data being reported. The reconciliation data is part of ApplyResults https://searchfox.org/mozilla-central/source/third_party/rust/sync15-traits/src/bridged_engine.rs#81, and is dropped on the floor https://searchfox.org/mozilla-central/source/services/sync/golden_gate/src/task.rs#310. Threading it through is all that's still needed.

Original comment: We already define types for ping / engine ping in sync15_traits, but need golden_gate (rust) engines to support it.

Comment 1

[Lina Butler [:lina]]

Good call! Are there any special hooks we want to add to the Rust bridge, like for steps and validation? Subclassing BridgedEngine on the JS side will give us the basic events and include them in the Sync ping like any other engine, but step and validate:finish would need to be bubbled up from Rust, something like what we do for bookmarks.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

As mentioned, the only part of this we don't currently collect is reconciliation data, and we don't really care about that much.

Time to file a follow up for removing it from the sync ping all-together.