Closed
Bug 1628905
Opened 5 years ago
Closed 5 years ago
Remove, preserve and reinstate more attributes that can mess up the appearance of customizeToolbar dialog
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
RESOLVED
FIXED
seamonkey2.53
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.3)
Attachments
(2 files)
|
2.56 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
|
2.54 KB,
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Some attributes are already removed in cleanUpItemForPalette, preserved in cleanupItemForToolbar or reinstated in restoreItemForToolbar
At the moment:
- checked is already preserved/reinstated but not removed in cleanUpItemForPalette
- collapsed is neither preserved/reinstated nor removed
The format toolbar has elements that have these attributes so this will need fixing.
Attachment #9139638 -
Flags: review?(frgrahl)
Attachment #9139638 -
Flags: approval-comm-release?
Attachment #9139639 -
Flags: review?(frgrahl)
Attachment #9139639 -
Flags: approval-comm-esr60?
|
||
Comment 3•5 years ago
|
||
Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)
Severity: normal → --
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9139638 [details] [diff] [review]
Work with more attributes for 2.53
LGTM
Attachment #9139638 -
Flags: review?(frgrahl)
Attachment #9139638 -
Flags: review+
Attachment #9139638 -
Flags: approval-comm-release?
Attachment #9139638 -
Flags: approval-comm-release+
|
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9139639 [details] [diff] [review]
Work with more attributes for 2.57
LGTM
Attachment #9139639 -
Flags: review?(frgrahl)
Attachment #9139639 -
Flags: review+
Attachment #9139639 -
Flags: approval-comm-esr60?
Attachment #9139639 -
Flags: approval-comm-esr60+
|
|
||
Comment 6•5 years ago
|
||
2.53 and 2.57 only.
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
tracking-seamonkey2.53:
--- → ?
tracking-seamonkey2.57esr:
--- → ?
|
|
||
Comment 7•5 years ago
|
||
Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/48613e0bfa94b9f8c60f16a1e3369b968bc864ce
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.3
Target Milestone: --- → seamonkey2.53
|
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•