1628994 - Blank area in Browser Console when devtools.chrome.enabled = false

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Julian Descottes [:jdescottes]]

Attachment: image.png

Just a minor visual nit:

STRs:

• set devtools.chrome.enabled to false
• open the Browser Console
• you will see a blank area instead of the input (more noticeable with the multi-line editor sidepanel)

I doubt this impacts many users, I suppose most BrowserConsole users have the pref enabled?

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

erf, and the toolbar shouldn't be visible as well

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I think there might be multiple things that should not be visible when the pref isn't on:

• the editor toolbar
• the editor input
• the instant evaluation element in in-line mode

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1628994 - Don't render input related elements in browser console when devtools.chrome.enabled is not true. r=jlast.

When the pref is not set to true, we should not display the input,
but also the editor toolbar, the instant evaluation result and
the editor resizer.
The existing test is modified to ensure we cover all these elements.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c00da8e9e19a
Don't render input related elements in browser console when devtools.chrome.enabled is not true. r=jlast.

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a6c81f67760
Backed out changeset c00da8e9e19a for causing perma dt failures in devtools/client/webconsole/test/browser/browser_console_eager_eval.js CLOSED TREE

Comment 6

[Stefan Hindli [:stefan_hindli]]

Backed out changeset c00da8e9e19a (Bug 1628994) for causing perma dt failures in devtools/client/webconsole/test/browser/browser_console_eager_eval.js CLOSED TREE

https://hg.mozilla.org/integration/autoland/rev/6a6c81f677609e91bb248cf5129f83da9ab61ee8

https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=297692749&fromchange=a7235bdaa392b40512559d6a4a578adfb4a1fc44&searchStr=linux%2C18.04%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-linux1804-64-shippable%2Fopt-mochitest-devtools-chrome-e10s-4%2Cm%28dt4%29

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297692749&repo=autoland&lineNumber=1921

Comment 7

[Andreea Pavel [:apavel]]

Also caused failures like this https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297708503&repo=autoland&lineNumber=3033

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3441d1bec516
Don't render input related elements in browser console when devtools.chrome.enabled is not true. r=jlast.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

I fixed the failures (the devtools ones, the accessibility test failure looked unrelated?)

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3441d1bec516