Consolidate throbber UI
Categories
(SeaMonkey :: UI Design, enhancement)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.3)
Attachments
(3 files, 2 obsolete files)
|
24.77 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
24.70 KB,
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
|
2.18 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
This has been bothering me for a while and, now that Bug 1628928 has tidied up some code, it is possible to remove some code / string duplication for the various throbbers.
This patch:
- Moves throbber code / strings into utilityOverlay
- Removes some duplication of overlay loading from mailnews
Removed changes from unpublished patch. Patch order I have is:
606683-customiseEditToolbar.patch
1628372-hide-sync-button.patch
1628412-fix-find.patch
1628485-fixEditorClose.patch
1628873-mergeEditorSmiley.patch
1628890-port714390-v1_1.patch
1628928-editorThrobber.patch
1629079-mergeThrobber.patch
As discussed on irc, we use the same throbber URL everywhere so we might as well just use a single pref (browser.throbber.url) for them all. This makes it even simpler and more code clean-up.
|
||
Comment 4•4 years ago
|
||
Comment on attachment 9146964 [details] [diff] [review] Merge throbber code with only one url LGTM
|
|
||
Comment 6•4 years ago
|
||
I believe the preference editor.throbber.url is dead in Thunderbird since the editor code was forked.
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/216dd6f69088
Consolidate throbber UI. r=frg DONTBUILD
|
|
||
Updated•4 years ago
|
|
||
Comment 8•4 years ago
|
||
Comment on attachment 9147020 [details] [diff] [review] 1629079-unthrobber.patch Review of attachment 9147020 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! r=mkmelin
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/93508184bcac Remove obsolete editor.throbber.url pref. r=mkmelin DONTBUILD
|
|
||
Comment 10•4 years ago
|
||
Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/267d6abe5a49771495e8e2912459f50e3d62b54a
Consolidate throbber UI. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/9973dac8332594cb3475c638279975b831024125
Remove obsolete editor.throbber.url pref. r=mkmelin a=me
Description
•