1629081 - [Automated review] Does not seem to cope with c++ structured bindings

Status: NEW

(Developer Infrastructure :: Source Code Analysis, defect, P2)

Description

[Byron Campen [:bwc]]

Phabricator URL: https://phabricator.services.mozilla.com/D70400

https://en.cppreference.com/w/cpp/language/structured_binding

This feature is allowed in mozilla code according to https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code

This feature is not used much in our codebase yet, but it does show up:

https://searchfox.org/mozilla-central/source/media/webrtc/signaling/src/sdp/RsdparsaSdpAttributeList.cpp#699

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Andi [:andi]]

Looking other the log this has nothing to do with the C++ structured bindings but more with range based loops, at least from the log we can see:
FIXME: Unconsumed set of 2 nodes: /CXXForRangeStmt

Comment 4

[Byron Campen [:bwc]]

Maybe it is trying to warn that we're using a structured binding with two things in it, but only using one of them inside the loop, and somehow getting tripped up trying to report that? That's a reasonable thing to warn about.

Comment 5

[Andi [:andi]]

Yes, that could be a lead but the problem is that we cannot reproduce this issue.