Closed Bug 1629089 Opened 4 months ago Closed 3 months ago

[wpt-sync] Sync PR 22857 - Handle k-rate AudioParam inputs for BiquadFilterNode

Categories

(Core :: Web Audio, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22857 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22857
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Handle k-rate AudioParam inputs for BiquadFilterNode

Support k-rate input to AudioParams for a BiquadFilterNode.
Previously, inputs to a k-rate AudioParam was ignored, which is
incorrect. The input must be summed with any timeline value.

Manually ran the new test case with Chrome stable and all the tests fail
as expected.

Bug: 1015760
Test: k-rate-biquad-connections.html
Change-Id: Iec7b57fe3b730d4f5984e223fde9cef9a4402103
Reviewed-on: https://chromium-review.googlesource.com/2144687
WPT-Export-Revision: 544f17a2c9a83c1653d1a3112bda105e03a9314f

Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 72 tests

Status Summary

Firefox

OK : 1
PASS: 100[GitHub] 171[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
PASS: 86
FAIL: 14

Safari

OK : 1
PASS: 8
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4399371f8772
[wpt PR 22857] - Handle k-rate AudioParam inputs for BiquadFilterNode, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74d257741038
[wpt PR 22857] - Handle k-rate AudioParam inputs for BiquadFilterNode, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.