1629127 - Implement migration telemetry for the move to rust-based webext sync storage.

Status: RESOLVED FIXED

(WebExtensions :: Storage, enhancement, P2)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

Using the migration telemetry we submitted for the various fennec -> fenix changes is likely a good base. This needs further investigation to be concrete, though.

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1629127 - Add sync telemetry for storage.sync migration

Bug 1629127 - Update vendored application-services to include migration
telemetry patch (1/2) r?lina Bug 1629127 - Record migration telemetry for
services.sync migration in the sync ping (2/2) r?lina

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

This is only 90% done but I'm getting it up now so I can request review/data-review as I figure out an issue in the test.

Also that was supposed to be 2 commits :(

Comment 3

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 9154671 [details]
Bug 1629127 - Add sync telemetry for storage.sync migration

(SORRY MESSED THIS UP)

Comment 4

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Data review request

Sorry about that. I think I did it right this time maybe?

Comment 5

[Thom Chiovoloni [:tcsc] (ex-moco)]

Okay, this is all wrapped up on my end (well, for now).

https://github.com/mozilla-services/mozilla-pipeline-schemas/issues/559 tracks updating moz-pipeline-schemas, I'll do that next chance I get.

Comment 6

[Chris H-C :chutten]

Comment on attachment 9154677 [details]
Data review request

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is documented in its [in-tree documentation](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/sync-ping.html).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No, :tcsc intendes to remove or renew the collection within 6 months.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :tcsc is responsible for renewing or removing the collection within six months' time.

---
Result: datareview+

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/560

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bc837c29a82
Add sync telemetry for storage.sync migration r=lina,extension-reviewers,mixedpuppy

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1bc837c29a82

Comment 10

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 9154671 [details]
Bug 1629127 - Add sync telemetry for storage.sync migration

Beta/Release Uplift Approval Request

• User impact if declined: We won't be able to detect bugs in the migration process and thus some users may experience data loss when migration lands without pref blockage.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: N/A
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Limited to sync telemetry, code in question only runs once ever.
• String changes made/needed: N/A

Comment 11

[Thom Chiovoloni [:tcsc] (ex-moco)]

(Note that part of why I'm requesting review is because this stands in the way of bug 1645598 -- on its own I'm not sure we'd bother -- that said, it could provide valuable information nonetheless!)

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9154671 [details]
Bug 1629127 - Add sync telemetry for storage.sync migration

approved for 78.0b8

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/39c699898ba3