1629132 - Update new password heuristics to model at 96d83b2

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Description

[Bianca Danforth [:bdanforth]]

Bug 1595244 introduced a machine learning model using Fathom to improve detection of new password fields for password generation (v1) which was updated in Bug 1625601 (v2) mostly for accuracy improvements on password change forms and a slight performance bump.

The upstream model has since been updated with the following changes:

• Reformat rulesets.js to comply with Mozilla eslint rules
• Low risk performance improvements to the model shipped in Bug 1625601
  • This was motivated by Nightly 76 telemetry data (Bug 1619498) comparing Beta 75 (no model), v1 and v2.

The latter change will improve the running time of _isProbablyANewPasswordField by around 23%.

Comment 1

[Bianca Danforth [:bdanforth]]

Attachment: Bug 1629132 - Update new password heuristics to model at 96d83b2

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d76253b9b59
Update new password heuristics to model at 96d83b2 r=MattN

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6d76253b9b59

Comment 4

[Bianca Danforth [:bdanforth]]

Comment on attachment 9139847 [details]
Bug 1629132 - Update new password heuristics to model at 96d83b2

Beta/Release Uplift Approval Request

• User impact if declined: This patch represents a modest performance improvement for the associated Password Manager feature; if declined, the time it takes to show the password generation option in the autocomplete popup will be about 13% slower on average.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The risk is whether the performance changes made in the patch affect the accuracy of the feature (i.e. correctly determining whether or not to show the password generation option in the autocomplete popup on new password fields). However, we have already verified that the accuracy of this update is at parity with the accuracy for the existing feature shipped in Firefox 76 (Bug 1595244 and Bug 1625601) based on a set of a couple hundred web pages used to develop the feature. Also, our existing tests covering this feature are passing, and the feature's conversion rates from telemetry in Nightly 77 are unchanged from those we are seeing for the feature we're updating in Beta 76. Finally, this feature is gated behind the pref signon.generation.confidenceThreshold, and it can be disabled by setting it to -1.
• String changes made/needed:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9139847 [details]
Bug 1629132 - Update new password heuristics to model at 96d83b2

Thanks for the thorough risk assessment. Approved for 76.0b5.

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/443244a3a9cb