1629137 - Search Tips break Disable Popup Auto-Hide in Browser Toolbox

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[bug.zilla]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Opened Browser Toolbox and selected Disable Popup Auto-Hide.
Typed a few characters in the url bar to expand it.

Actual results:

Switched back to Browser Toolbox and url bar shrunk.

Expected results:

Url bar should remain expanded.
Note: this works correctly with menu dropdowns as they remain visible.

I've tried with Firefox v. 75 and Developer Edition v. 76.
And also in Safe Mode.

Can anyone replicate?
Thanks.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Marco Bonardo [:mak]]

Could you please better specify what you do after enabling the Disable Popup Auto-Hide option? Off-hand I cannot reproduce if I just open the urlbar and then click on content, for example, it stays open. If I open a new tab it closes. It's likely not all the cases are handled, thus I'm asking the specific steps.

Comment 3

[bug.zilla]

Hi,

you're correct: if you expand the url bar and then click anywhere within the page, the url bar remains expanded.

I was referring to switching back to the Browser Toolbox (for example to use the element picker on the url bar results, or to use the Style Editor).
Once I switch to the Browser Toolbox, the url bar shrinks.

Or to put it another way, how can one select elements in the expanded url bar?

Thanks

Comment 4

[Marco Bonardo [:mak]]

it looks like that broke, it was working until some time ago because I was using it for development.

Comment 5

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=36fe73abeebf1fd32de4df2827dec16e4e26c03d&tochange=7478c4a8f259959f01f91ec4229c6ea896ed932a

Comment 6

[Harry Twyford]

Attachment: Bug 1629137 - Respect ui.popup.disable_autohide in UrlbarView._on_blur. r?adw

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/021fcf51ae41
Respect ui.popup.disable_autohide in UrlbarView._on_blur. r=adw

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/021fcf51ae41

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 77.0a1 (BuildId:20200410213700) on Windows 10 64bit.

This issue is verified fixed using Firefox 77.0b7 (BuildId:20200515125749) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit.