1629175 - refactor updatePrefs to use new registerStoreHelper

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Jason Laster [:jlast]]

The new helpers simplifies the code and makes it a bit more bulletproof

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1629175 - refactor updatePrefs to use new registerStoreHelper. r=davidwalsh

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0428d442d059
refactor updatePrefs to use new registerStoreHelper. r=davidwalsh

Comment 3

[Daniel Varga [:dvarga]]

Backed out changeset 0428d442d059 (Bug 1629175) for causing devtools failures at devtools/client/framework/test/metrics/browser_metrics_debugger.j

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=0428d442d0599e2a67301a3dab709065e68be239

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297630117&repo=autoland&lineNumber=18113

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=c224327f2bddd5f1a00b2c8edc6b098188884202

[task 2020-04-14T23:59:08.918Z] 23:59:08     INFO - TEST-START | devtools/client/framework/test/metrics/browser_metrics_debugger.js
[task 2020-04-14T23:59:09.004Z] 23:59:09     INFO - Entering test bound 
[task 2020-04-14T23:59:09.004Z] 23:59:09     INFO - Adding a new tab with URL: data:text/html;charset=UTF-8,<div>Debugger modules load test</div>
[task 2020-04-14T23:59:09.612Z] 23:59:09     INFO - Tab added and finished loading
[task 2020-04-14T23:59:09.612Z] 23:59:09     INFO - Opening the toolbox
[task 2020-04-14T23:59:10.011Z] 23:59:10     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 78}]
[task 2020-04-14T23:59:10.632Z] 23:59:10     INFO - Toolbox opened and focused
[task 2020-04-14T23:59:10.633Z] 23:59:10     INFO - TEST-INFO | started process screentopng
[task 2020-04-14T23:59:10.915Z] 23:59:10     INFO - TEST-INFO | screentopng: exit 0
[task 2020-04-14T23:59:10.915Z] 23:59:10     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/metrics/browser_metrics_debugger.js | Duplicated module load detected. List of duplicated modules:
[task 2020-04-14T23:59:10.915Z] 23:59:10     INFO -   [duplicated module] resource://devtools/client/shared/redux/subscriber.js
[task 2020-04-14T23:59:10.915Z] 23:59:10     INFO -  - Got 1, expected 0
[task 2020-04-14T23:59:10.915Z] 23:59:10     INFO - Stack trace:
[task 2020-04-14T23:59:10.916Z] 23:59:10     INFO - chrome://mochikit/content/browser-test.js:test_is:1302
[task 2020-04-14T23:59:10.916Z] 23:59:10     INFO - chrome://mochitests/content/browser/devtools/client/framework/test/metrics/head.js:runDuplicatedModulesTest:163
[task 2020-04-14T23:59:10.916Z] 23:59:10     INFO - chrome://mochitests/content/browser/devtools/client/framework/test/metrics/browser_metrics_debugger.js:null:44
[task 2020-04-14T23:59:10.917Z] 23:59:10     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1044
[task 2020-04-14T23:59:10.917Z] 23:59:10     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1079
[task 2020-04-14T23:59:10.917Z] 23:59:10     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:909
[task 2020-04-14T23:59:10.917Z] 23:59:10     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-04-14T23:59:10.918Z] 23:59:10     INFO - PERFHERDER_DATA: {"framework":{"name":"devtools"},"suites":[{"name":"debugger-metrics","value":7186278,"subtests":[{"name":"debugger-modules","value":194},{"name":"debugger-chars","value":1331347},{"name":"all-modules","value":399},{"name":"all-chars","value":7186278}]}]}

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9871d664af2e
Backed out changeset 0428d442d059 for causing devtools failures at devtools/client/framework/test/metrics/browser_metrics_debugger.j

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/941293364d96
refactor updatePrefs to use new registerStoreHelper. r=davidwalsh

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/941293364d96